Skip to content

[ServiceBus] Graceful noops for methods taking empty lists.#15286

Merged
3 commits merged intoAzure:masterfrom
KieranBrantnerMagee:kibrantn/servicebus/track2-pre-ga-graceful-noop-empty-arrays
Nov 19, 2020
Merged

[ServiceBus] Graceful noops for methods taking empty lists.#15286
3 commits merged intoAzure:masterfrom
KieranBrantnerMagee:kibrantn/servicebus/track2-pre-ga-graceful-noop-empty-arrays

Conversation

@KieranBrantnerMagee
Copy link
Member

Make send_messages, schedule_messages, cancel_scheduled_messages, and receive_deferred_messages gracefully no-op when provided an empty list or empty batch (where appropriate). Adds tests and changelog notes for these scenarios. Closes #15211

… receive_deferred_messages gracefully no-op when provided an empty list or empty batch (where appropriate). Adds tests and changelog notes for these scenarios. Closes Azure#15211
@KieranBrantnerMagee KieranBrantnerMagee added Service Bus Client This issue points to a problem in the data-plane of the library. labels Nov 12, 2020
@KieranBrantnerMagee KieranBrantnerMagee added this to the [2020] December milestone Nov 12, 2020
@KieranBrantnerMagee KieranBrantnerMagee self-assigned this Nov 12, 2020
@KieranBrantnerMagee
Copy link
Member Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@KieranBrantnerMagee
Copy link
Member Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

rakshith91
rakshith91 previously approved these changes Nov 18, 2020
@KieranBrantnerMagee
Copy link
Member Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Comment was made before the most recent commit for PR 15286 in repo Azure/azure-sdk-for-python

Copy link
Member

@annatisch annatisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KieranBrantnerMagee
Copy link
Member Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost
Copy link

ghost commented Nov 19, 2020

Hello @KieranBrantnerMagee!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 9926619 into Azure:master Nov 19, 2020
iscai-msft added a commit that referenced this pull request Nov 19, 2020
…into feature/textanalytics5.2

* 'master' of https://github.com/Azure/azure-sdk-for-python: (40 commits)
  Sync eng/common directory with azure-sdk-tools for PR 1203 (#15441)
  [ServiceBus] Graceful noops for methods taking empty lists. (#15286)
  [text analytics] add sample stories and improve documents (#15429)
  [ServiceBus] Enable FQDNs and connection strings to support newlines and protocol prefixing (e.g. sb://) (#15212)
  Fix combined session+auto-auto_lock_renewer+receive-and-delete mode issue where registry would fail during receipt.  Add tests and changelog entry. (#15343)
  Add Update-python-CIConfig (#15379)
  Remove aiodns from our CI (#15424)
  Resolve Broken Portal Link (#15431)
  [Key Vault] Update tests which disable soft-delete (#15352)
  switching order on readme (#15426)
  [text analtyics] add abby as codeowner (#15376)
  test (#15402)
  fix iothub version (#15405)
  [T2] Batch (#14757)
  [T2] Policyinsights (#14794)
  [T2] apimanagement Wave3 (#14804)
  [T2] devtestlabs Wave3 (#14795)
  [T2]eventgrid wave3 (#14805)
  [T2] Search (#14823)
  test,version,CHANGELOG (#14838)
  ...
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client This issue points to a problem in the data-plane of the library. Service Bus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ServiceBus] Graceful no-op for empty array input to certain methods

4 participants