Re-Add ChangeLog Verification with packaging installed#15373
Merged
chidozieononiwu merged 1 commit intoAzure:masterfrom Nov 19, 2020
Merged
Conversation
chidozieononiwu
requested review from
danieljurek,
mitchdenny,
scbedd and
weshaggard
as code owners
chidozieononiwu
force-pushed
the
ReEnableChangeLogWithPythonVersioning
branch
from
fe68fff to
f422a00
Compare
weshaggard
reviewed
Nov 18, 2020
weshaggard
previously approved these changes
Nov 18, 2020
Member
weshaggard
left a comment
weshaggard
left a comment
There was a problem hiding this comment.
One question but otherwise looks good. Please do a full release of a template package to ensure this step is hit and runs correctly.
chidozieononiwu
force-pushed
the
ReEnableChangeLogWithPythonVersioning
branch
from
f422a00 to
aa1b689
Compare
scbedd
approved these changes
Nov 19, 2020
iscai-msft
added a commit
that referenced
this pull request
Nov 19, 2020
…into feature/textanalytics5.2 * 'master' of https://github.com/Azure/azure-sdk-for-python: fix cog preparer (#15454) [text analytics] update changelog and classifiers (#15452) Some README tweaks (#15449) Re-Add ChangeLog Verification with packaging installed (#15373)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@scbedd This adds back the changelog verification with the python versioning installed.
I will run a test release to ensure this works.
Sorry for the inconvenience with this issue.