add python 3.9 to live test matrix#15488
Merged
kristapratico merged 1 commit intoAzure:masterfrom Nov 20, 2020
Merged
Conversation
kristapratico
requested review from
danieljurek,
mitchdenny and
weshaggard
as code owners
weshaggard
reviewed
Nov 20, 2020
| Linux_Python39: | ||
| OSVmImage: 'ubuntu-18.04' | ||
| PythonVersion: '3.8' | ||
| PythonVersion: '3.9.0' |
Member
There was a problem hiding this comment.
Not sure it matters but is there a reason this is 3.9.0 instead of 3.9?
Contributor
Author
There was a problem hiding this comment.
Hm not sure. I copied this from the servicebus tests.yml. Will wait on final say from @scbedd
Member
There was a problem hiding this comment.
IMO this is fine. I will check if py39 has been added to the actual images themselves. We would use 3.9 like you're asking if it is already on the machine Wes.
Member
There was a problem hiding this comment.
Given that this would need to be changed in 3 or so locations. This should probably just merge.
weshaggard
approved these changes
Nov 20, 2020
Member
weshaggard
left a comment
weshaggard
left a comment
There was a problem hiding this comment.
Change looks reasonable to me assuming we are good with removing the 38 testing and replace it with 3.9.
scbedd
approved these changes
Nov 20, 2020
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-python
that referenced
this pull request
Aug 3, 2021
Update web readme and readme.python (Azure#15488) * Update web readme and readme.python * Update readme
msyyc
pushed a commit
that referenced
this pull request
Aug 19, 2021
* CodeGen from PR 15488 in Azure/azure-rest-api-specs Update web readme and readme.python (#15488) * Update web readme and readme.python * Update readme * version,CHANGELOG Co-authored-by: SDKAuto <sdkautomation@microsoft.com> Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
iscai-msft
pushed a commit
that referenced
this pull request
Sep 29, 2021
* CodeGen from PR 15488 in Azure/azure-rest-api-specs Update web readme and readme.python (#15488) * Update web readme and readme.python * Update readme * version,CHANGELOG Co-authored-by: SDKAuto <sdkautomation@microsoft.com> Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.