Required params must be positional#16194
Merged
rakshith91 merged 5 commits intoAzure:masterfrom Jan 15, 2021
Merged
Conversation
ghost
added
the
rakshith91
added
the
Client
rakshith91
requested review from
KieranBrantnerMagee and
lmazuel
as code owners
lmazuel
reviewed
Jan 15, 2021
| ## 2.0.0b5 (Unreleased) | ||
|
|
||
| **Breaking Changes** | ||
| - `EventGridEvent` has two additional required positional parameters namely, `data` and `data_version`. |
Member
There was a problem hiding this comment.
It's a bug fix, since no calls could succeed in the past without those two, it means people had to add them manually. So this PR is mostly acknowledging to people that yes, our IntelliSense was crap.
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Jan 20, 2021
…into fix_autorest_links * 'master' of https://github.com/Azure/azure-sdk-for-python: (44 commits) Added credscan steps for python (Azure#16136) [Communication] Move core dependency to setup.py from dev_requirements in communication management package (Azure#16077) Increment package version after release of azure_security_attestation (Azure#16218) T2 compute 2021 01 19 (Azure#16246) Update error message in tools repo (Azure#16245) Add LanguageDisplayName variable to LanguageSettings file (Azure#16239) Fix Eventgrid sample (Azure#16217) Adding 2020-09-01-hybrid profile (Azure#14642) Increment version for storage releases (Azure#16152) Increment package version after release of azure_storage_file_datalake (Azure#16157) make the globbing of the packages work in dev_setup from any invocation directory (Azure#16209) [Queues] Generated Queues using newest autorest version (Azure#16148) T2 confluent 2021 01 15 (Azure#16221) we are using a pool not a specific vmImage (Azure#16213) Naming Feedback - part 2 (Azure#16210) Naming feedback - part 1 (Azure#16208) Raise on bad credential (Azure#16206) Updated release date (Azure#16205) Required params must be positional (Azure#16194) Replace EventgridSharedAccessSignatureCredential with AzureSasCredential (Azure#16147) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15959
Some of the params in the eventgrid event are required, but have nbeen sitting as a kwarg. Need to flatten them as positional