move cloud events to azure core

[rakshith91]

Fixes #16585

Adding CloudEvent to azure-core as follows:

from azure.core.messaging import CloudEvent

[lmazuel]

• ascii is enough, per base64 spec.
• I'm not even sure we need to encode, could you describe the scenario where we do?

[johanste]

Yeah, this method is confusing to me. Is the only reason for it to exist to normalize the exception type?

[rakshith91]

yes - thinking about it, i think we dont need this method at all - removing it

[lmazuel]

https://docs.python.org/3/library/datetime.html#datetime.datetime.utcnow
Warning Because naive datetime objects are treated by many datetime methods as local times, it is preferred to use aware datetimes to represent times in UTC. As such, the recommended way to create an object representing the current time in UTC is by calling datetime.now(timezone.utc).

Problem is, Python 2 doesn't have timezone.utc. @johanste usually I tell people to use msrest.serialization.utc since they use msrest as a dependency anyway, but here it won't work. Though?

[rakshith91]

updated

[lmazuel]

I would expect an error if both data and data_base64 are present for clarity

[rakshith91]

I agree with it, but if we ever decide to add data_base64 in the future, this error would cause a breaking change - thoughts?

[lmazuel]

why?

[rakshith91]

bad copying ;) - removed it

[lmazuel]

I actually find it confusing to have the body in another file here. Could we get rid of the _mock.py file and insert the dict here?

[xiangyan99]

1.12.0

[xiangyan99]

Please separate core changes and event hub changes into different PRs.

[xiangyan99]

We don't need explicit "Optional." for keyword arguments. Right? :)

[rakshith91]

hmm, not sure if it's a good practice - but there can certainly be "required" keyword only params (hopefully not in our libraries, but still possible) - thought no harm in mentioning it's optional :)

[xiangyan99]

Given we already pass **kwargs into cls, why we need id=event.pop("id", None), etc.?

[rakshith91]

hmm, intentionally popping them since we want to have the remainder of the dict as "extensions"

[xiangyan99]

Please give the file a more specific name.

[xiangyan99]

And you also need to bump the core dependency version to 1.12.0 for event grid. :)

[rakshith91]

Please review core related chages here
Add cloud event to core by rakshith91 · Pull Request #16800 · Azure/azure-sdk-for-python (github.com)

[iscai-msft]

/azp run python - autorest - pr

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).