models wrapping + sdk integration with generated client#17071
models wrapping + sdk integration with generated client#17071mshaban-msft wants to merge 5 commits intoAzure:document-translationfrom
Conversation
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
kristapratico
left a comment
kristapratico
left a comment
There was a problem hiding this comment.
I know this is work in progress, just some early feedback. looking good :)
sdk/documenttranslation/azure-ai-documenttranslation/azure/ai/documenttranslation/_client.py
Show resolved
Hide resolved
|
|
||
| return self._client.document_translation.get_glossary_formats(**kwargs) | ||
| glossary_formats = self._client.document_translation.get_glossary_formats(**kwargs) | ||
| return FileFormat._from_generated_list(glossary_formats) |
There was a problem hiding this comment.
would it work to fold the helper methods into one like this?
return [FileFormat._from_generated(glossary_format) for glossary_format in glossary_formats.value]
There was a problem hiding this comment.
i used to do it inline, but i thought it's much cleaner if i created "_from_generated_list()" to process lists
instead of having to same code for the same object over and over
| def _from_generated(cls, file_format): | ||
| return cls( | ||
| format=file_format.format, | ||
| file_extentions=file_format.file_extentions, |
There was a problem hiding this comment.
| file_extentions=file_format.file_extentions, | |
| file_extensions=file_format.file_extensions, |
sdk/documenttranslation/azure-ai-documenttranslation/azure/ai/documenttranslation/_models.py
Show resolved
Hide resolved
sdk/documenttranslation/azure-ai-documenttranslation/azure/ai/documenttranslation/_models.py
Show resolved
Hide resolved
sdk/documenttranslation/azure-ai-documenttranslation/azure/ai/documenttranslation/_models.py
Show resolved
Hide resolved
sdk/documenttranslation/azure-ai-documenttranslation/azure/ai/documenttranslation/_models.py
Show resolved
Hide resolved
sdk/documenttranslation/azure-ai-documenttranslation/azure/ai/documenttranslation/_models.py
Show resolved
Hide resolved
[Hub Generated] Review request for Microsoft.Confluent to add version stable/2021-12-01 (Azure#17070) * Adds base for updating Microsoft.Confluent from version preview/2021-09-01-preview to version 2021-12-01 * Updates readme * Updates API version in new specs and examples * Fixing spellcheck and updating readme files (Azure#17071) * Update confluent.json (Azure#18254) Fixing linting errors * Update confluent.json for LintDiff fixes (Azure#18261)
2 participants
No description provided.