Skip to content

Add any additional claims to AuthenticationRequiredError#17136

Merged
chlowell merged 3 commits intoAzure:masterfrom
chlowell:auth-required-error
Mar 5, 2021
Merged

Add any additional claims to AuthenticationRequiredError#17136
chlowell merged 3 commits intoAzure:masterfrom
chlowell:auth-required-error

Conversation

@chlowell
Copy link
Member

@chlowell chlowell commented Mar 5, 2021

This preserves additional claims passed to an interactive credential's get_token() on AuthenticationRequiredError, via a claims property, enabling an application that has disabled automatic authentication to request those claims in a subsequent get_token() call.

@chlowell chlowell added Client This issue points to a problem in the data-plane of the library. Azure.Identity labels Mar 5, 2021
@chlowell chlowell requested review from mccoyp and schaabs as code owners March 5, 2021 20:27
Copy link
Member

@mccoyp mccoyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love how descriptive the docstring for AuthenticationRequiredError is!

@chlowell chlowell merged commit 4300118 into Azure:master Mar 5, 2021
@chlowell chlowell deleted the auth-required-error branch March 5, 2021 22:01
iscai-msft added a commit that referenced this pull request Mar 8, 2021
…into update_ta_tests

* 'master' of https://github.com/Azure/azure-sdk-for-python:
  Update get_package_properties.py logic for python 2.7 (#17144)
  update changelog (#17150)
  [ServiceBus] 7.1.0 Release update changelog (#17135)
  [ServiceBus] Object mapping support (#17080)
  move SetTestPipeline into its own template (#17141)
  Revise token cache configuration API (#16326)
  Fix dup cloud error (#17097)
  Perf tests for monitor exporter (#17067)
  [Communication] - Phone Number - Redesigned API (#16671)
  disable retry (#17078)
  [Key Vault] Add perf tests for certificates, keys, and secrets (#17073)
  [text analytics] Analyze updates for v5.1.0b6 (#17003)
  Add any additional claims to AuthenticationRequiredError (#17136)
  Fix logic in SetTestPipelineVersionInEngCommon (#17138)
  [Key Vault] Make test resource cleanup script asynchronous (#17032)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure.Identity Client This issue points to a problem in the data-plane of the library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants