[Key Vault] Target multiple API versions with tests (secrets)#18183
Merged
mccoyp merged 5 commits intoAzure:masterfrom Apr 26, 2021
Merged
[Key Vault] Target multiple API versions with tests (secrets)#18183mccoyp merged 5 commits intoAzure:masterfrom
mccoyp merged 5 commits intoAzure:masterfrom
Conversation
mccoyp
added
KeyVault
Client
chlowell
approved these changes
Apr 23, 2021
| test_class_instance._skip_if_not_configured(api_version) | ||
| client = test_class_instance.create_client(azure_keyvault_url, api_version=api_version, **kwargs) | ||
|
|
||
| if kwargs.get("is_async"): |
Member
There was a problem hiding this comment.
Do you need is_async for anything else? If not, consider this: https://github.com/Azure/azure-sdk-for-python/blob/2794bfcc88aad415920c234a848701f2bcfeeb88/tools/azure-devtools/src/azure_devtools/scenario_tests/preparers.py#L145-155
Member
Author
There was a problem hiding this comment.
is_async is also provided to create_client, but I'll keep this in mind!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #12376 -- same methodology as #16979, with added decorator work from #18149.