Conversation
ghost
added
the
xiangyan99
requested review from
00Kai0,
changlong-liu,
jsntcy and
msyyc
as code owners
| if not config.http_logging_policy: | ||
| config.http_logging_policy = kwargs.get('http_logging_policy', ARMHttpLoggingPolicy(**kwargs)) |
There was a problem hiding this comment.
These lines are unnecessary as the client will always have http_logging_policy configured:
There was a problem hiding this comment.
We need it because in your test case, you use the azure.core.configure which does not honor http_logging_policy.
w/o it will fail the tests.
There was a problem hiding this comment.
In azure-core, per_call_policies can be a list or object:
azure-sdk-for-python/sdk/core/azure-core/azure/core/_pipeline_client.py
Lines 125 to 129 in 6edb999
But here it can only be a list. Passing per_call_policies as an object causes failure in the append method.
|
/check-enforcer evaluate |
|
/check-enforcer reset |
| if isinstance(per_call_policies, Iterable): | ||
| per_call_policies.append(AsyncARMAutoResourceProviderRegistrationPolicy()) |
There was a problem hiding this comment.
append will fail if per_call_policies is a tuple, instead of a list:
AttributeError: 'tuple' object has no attribute 'append'
3 participants
No description provided.