add implementation for checkpointstoretable by Jg1255 · Pull Request #19905 · Azure/azure-sdk-for-python

Jg1255 · 2021-07-21T22:17:41Z

implementation changes made to checkpointstoretable

ghost · 2021-07-21T22:17:46Z

Thank you for your contribution Jg1255! We will review the pull request and get back to you soon.

add the test cases add the test file fix test file

swathipil · 2021-07-22T21:53:41Z

/azp run python - eventhub - ci

azure-pipelines · 2021-07-22T21:53:59Z

Azure Pipelines successfully started running 1 pipeline(s).

...nthub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py

…b/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

…sdk-for-python into josue_third_branch

shared_requirements.txt

...nthub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py

swathipil · 2021-08-13T17:00:21Z

...nthub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py

+                mode=UpdateMode.REPLACE,
+                entity=ownership_entity,
+                etag=ownership["etag"],
+                match_condition=MatchConditions.IfNotModified,


hmm, now that I think about it, why are we setting this as the MatchCondition? is this what Baffy did in JS?

I think we should remove this, b/c it implies that we only update the entity if it has not been modified before. However, if we call this method twice (or more) on the same entity, it should update it twice (or more).

so we actually need it cause without the match condition it will not update the owner_id and raise an exception

that's weird, but since we're not releasing this rn, I can check if this is the right approach later

...nthub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py

sdk/eventhub/azure-eventhub-checkpointstoretable/tests/test_storage_table_partition_manager.py

swathipil · 2021-08-13T17:45:11Z

sdk/eventhub/azure-mgmt-eventhub/dev_requirements.txt

-aiohttp>=3.0; python_version >= '3.5'
+../../core/azure-core
+../azure-eventhub
+../../tables/azure-data-tables


we shouldn't be touching this file at all since this is actually a management plane library. We on the data plane team are not in charge of this library. Let's undo these changes

so undoing the changes would mean adding this line again:
aiohttp>=3.0; python_version >= '3.5'

and removing these:

../../core/azure-core ../azure-eventhub ../../tables/azure-data-tables

…b/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

…orage_table_partition_manager.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

…b/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

swathipil · 2021-08-13T19:41:57Z

/azp run python - eventhub - tests

azure-pipelines · 2021-08-13T19:42:11Z

Azure Pipelines successfully started running 1 pipeline(s).

swathipil

sorry, left a few last comments 🤞

sdk/eventhub/azure-eventhub-checkpointstoretable/tests/test_storage_table_partition_manager.py

swathipil · 2021-08-13T19:49:23Z

sdk/eventhub/azure-mgmt-eventhub/dev_requirements.txt

-aiohttp>=3.0; python_version >= '3.5'
+../../core/azure-core
+../azure-eventhub
+../../tables/azure-data-tables


so undoing the changes would mean adding this line again:
aiohttp>=3.0; python_version >= '3.5'

and removing these:

../../core/azure-core ../azure-eventhub ../../tables/azure-data-tables

swathipil

LGTM!

chradek

Thank you for getting this implementation put together! And thanks @swathipil for reviewing!

…into have_pipelines_support_rest * 'main' of https://github.com/Azure/azure-sdk-for-python: (108 commits) Enable API review approval check for Java spring packages (Azure#20311) [AutoRelease] t2-iothubprovisioningservices-2021-07-15-81882 (Azure#19816) Increment package version after release of azure-eventgrid (Azure#20204) Sync eng/common directory with azure-sdk-tools for PR 1909 (Azure#20298) Rename attrs is metrics (Azure#20236) [EventHubs] checkpointstoretable - skip tests until env vars configured (Azure#20289) Update to use timespan (Azure#20233) Prevent wildcard expansion in git sparse checkout add (Azure#20267) Fix typo and polish the key concepts (Azure#18407) Fix IOT Device Update readme issue (Azure#18752) Add context manager API to azure.identity credentials (Azure#19746) Add support for 'files' configuration (Azure#20272) Update main for 30-close.py (Azure#20287) [AutoRelease] t2-purview-2021-08-13-30358 (Azure#20260) add implementation for checkpointstoretable (Azure#19905) Fix resource clean-up script (Azure#20273) [Tables] Fix bug in update mode (Azure#20264) Add Rest Method checks to Prepare-Release (Azure#20275) Update release date (Azure#20270) Update the release date for ACS chat 1.1.0b1 (Azure#20277) ...

* add implementation add the test cases add the test file fix test file * fix pylint * fix pylint * fix pylint * fix pylint * fix pylint * fix pylint * fix pylint * fix pylint * fix pylint * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * new update * Update shared_requirements.txt Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * environment * redo * redo * redo * changed variable name * changed variable name * Update sdk/eventhub/azure-eventhub-checkpointstoretable/tests/test_storage_table_partition_manager.py Co-authored-by: Sean Kane <68240067+seankane-msft@users.noreply.github.com> * update on test file * update on test file * update on test file * update based on feedack * new update * update * update * update * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: chradek <51000525+chradek@users.noreply.github.com> * new update * new * new * new * new * new * update on spacing * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: chradek <51000525+chradek@users.noreply.github.com> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: chradek <51000525+chradek@users.noreply.github.com> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: chradek <51000525+chradek@users.noreply.github.com> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: chradek <51000525+chradek@users.noreply.github.com> * new update * update * update on test file * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * update * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * update * update * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/tests/test_storage_table_partition_manager.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/tests/test_storage_table_partition_manager.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * update * update * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * update * Update sdk/eventhub/azure-eventhub-checkpointstoretable/tests/test_storage_table_partition_manager.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * update * Update sdk/eventhub/azure-eventhub-checkpointstoretable/tests/test_storage_table_partition_manager.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * update * update * update * update * update * update * Revert "update" This reverts commit d2dbb2a. * update * update * update * newupdate * update * update * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * update * update * update * update * update * update * update * update * update * update * update * update * update * update * update * update * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/samples/receive_events_using_checkpoint_store.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/setup.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/tests/test_storage_table_partition_manager.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/tests/test_storage_table_partition_manager.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * update * update * update * update * update * update * p * update * update * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/tests/test_storage_table_partition_manager.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/tests/test_storage_table_partition_manager.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/tests/test_storage_table_partition_manager.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * update * update * update Co-authored-by: Josue Garcia <t-jgarcia@microsoft.com> Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> Co-authored-by: Sean Kane <68240067+seankane-msft@users.noreply.github.com> Co-authored-by: chradek <51000525+chradek@users.noreply.github.com>

Jg1255 requested review from annatisch, rakshith91, swathipil and yunhaoling as code owners July 21, 2021 22:17

ghost added Event Hubs customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Jul 21, 2021

chradek self-requested a review July 21, 2021 22:17

Jg1255 force-pushed the josue_third_branch branch from 9be9b52 to 2f974c4 Compare July 21, 2021 22:37

add implementation

a6875dd

add the test cases add the test file fix test file

Jg1255 force-pushed the josue_third_branch branch from 2f974c4 to a6875dd Compare July 21, 2021 22:39

Josue Garcia added 9 commits July 21, 2021 23:16

fix pylint

6b6fd00

fix pylint

515f886

fix pylint

773020a

fix pylint

8b241bd

fix pylint

7a8a62d

fix pylint

63fb4cb

fix pylint

ffa5541

fix pylint

2986370

fix pylint

1f06d3c

Jg1255 closed this Jul 22, 2021

Jg1255 reopened this Jul 22, 2021

swathipil removed the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Jul 23, 2021

swathipil reviewed Jul 23, 2021

View reviewed changes

...nthub-checkpointstoretable/azure/eventhub/extensions/checkpointstoretable/_tablestoragecs.py Outdated Show resolved Hide resolved

Jg1255 and others added 3 commits July 23, 2021 13:07

Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhu…

68e6e05

…b/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

new update

be8362a

Merge branch 'josue_third_branch' of https://github.com/Jg1255/azure-…

29c7a84

…sdk-for-python into josue_third_branch

swathipil reviewed Jul 23, 2021

View reviewed changes

shared_requirements.txt Outdated Show resolved Hide resolved

Josue Garcia added 2 commits August 13, 2021 13:35

update

7c508e4

update

dbc12da

swathipil reviewed Aug 13, 2021

View reviewed changes

Jg1255 and others added 16 commits August 13, 2021 13:58

Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhu…

f93a037

…b/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhu…

a2b871c

…b/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhu…

d837f5b

…b/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhu…

43bbc11

…b/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhu…

141fbbd

…b/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

Update sdk/eventhub/azure-eventhub-checkpointstoretable/tests/test_st…

dca1f0d

…orage_table_partition_manager.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

Update sdk/eventhub/azure-eventhub-checkpointstoretable/tests/test_st…

74d73e1

…orage_table_partition_manager.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

Update sdk/eventhub/azure-eventhub-checkpointstoretable/tests/test_st…

de08199

…orage_table_partition_manager.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhu…

6553356

…b/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhu…

a6e9481

…b/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhu…

fb8fc57

…b/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhu…

96af725

…b/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhu…

de6ce7e

…b/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhu…

6be0ce9

…b/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

Update sdk/eventhub/azure-eventhub-checkpointstoretable/azure/eventhu…

0bce5e8

…b/extensions/checkpointstoretable/_tablestoragecs.py Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

update

b156941

Jg1255 requested a review from benbp as a code owner August 13, 2021 19:41

update

a545417

swathipil reviewed Aug 13, 2021

View reviewed changes

update

003f741

swathipil approved these changes Aug 13, 2021

View reviewed changes

chradek approved these changes Aug 13, 2021

View reviewed changes

swathipil merged commit c252444 into Azure:main Aug 14, 2021

Conversation

Jg1255 commented Jul 21, 2021

Uh oh!

ghost commented Jul 21, 2021

Uh oh!

swathipil commented Jul 22, 2021

Uh oh!

azure-pipelines bot commented Jul 22, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

swathipil commented Aug 13, 2021

Uh oh!

azure-pipelines bot commented Aug 13, 2021

Uh oh!

swathipil left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

swathipil left a comment

Choose a reason for hiding this comment

Uh oh!

chradek left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants