Closed
Conversation
Member
Author
|
Closing in favor of #20451 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a refresh_on property to AccessToken, allowing credentials a means to indicate when a token should be refreshed i.e. replaced. A mechanism like this is required by OnBehalfOfCredential (#20043), whose tokens should never be cached by callers, and has other potential uses. The default refresh_on value aligns with BearerTokenCredentialPolicy's current refresh behavior.
AccessToken is a namedtuple, making it tricky to extend without breaking code. My solution here is to override
__new__to return the expected tuple, and use__init__to initialize the new property. The resulting object can be constructed like the former tuple and behaves the same when used like a tuple but has the new property.