[Key Vault] Resolve mindependency check failure#20390
Closed
mccoyp wants to merge 1 commit intoAzure:mainfrom
Closed
[Key Vault] Resolve mindependency check failure#20390mccoyp wants to merge 1 commit intoAzure:mainfrom
mccoyp wants to merge 1 commit intoAzure:mainfrom
Conversation
ghost
added
the
Member
|
@mccoyp I have another PR #20391 that attempts addressing this as well! @xiangyan99 raised an issue and I just haven't responded yet until my prospective fix checks out. |
Member
Author
|
Oh nice, thank you! I figured this might not work (it evidently didn't), but your solution makes sense. I'll close this and give my thumbs-up to that PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to an updated
cryptographyrequirement forazure-identityKV packages are failing mindependency checks.azure-identityis only a dev requirement, so this is an effort to resolve the issue by bumpingazure-keyvault-keys'scryptographydev requirement only (still requiring only 2.1.4 to install the package).