Fix audience issue in container sample#20821
Closed
lambertpan wants to merge 1 commit intoAzure:mainfrom
Closed
Conversation
|
Thank you for your contribution lambertpan! We will review the pull request and get back to you soon. |
|
Hi @lambertpan, thanks for pointing it out. I have a PR about ACR sample updates, it includes the fix of "audience" issue. Thanks! |
Author
|
Thanks, I close this PR. |
|
@lambertpan is it released ? test sample: azure.mgmt.containerregistry import auth is working but not the client for ContainerRegistryClient |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
audience is required by ContainerRegistryClient(), however this part is missing from the /sdk/containerregistry/azure-containerregistry/samples, so added them.