Skip to content

[core] accept 'final-state-via' lro_options in base polling#22713

Merged
iscai-msft merged 9 commits into
Azure:mainfrom
iscai-msft:final_state_via_core
Feb 1, 2022
Merged

[core] accept 'final-state-via' lro_options in base polling#22713
iscai-msft merged 9 commits into
Azure:mainfrom
iscai-msft:final_state_via_core

Conversation

@iscai-msft
Copy link
Copy Markdown
Contributor

currently, azure-core polling doesn't do anything with the final-state-via information from open api definitions. This PR adds support for looking into final-state-via

@ghost ghost added the Azure.Core label Jan 21, 2022
@iscai-msft
Copy link
Copy Markdown
Contributor Author

/azp run python - formrecognizer - ci

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Comment thread sdk/core/azure-core/azure/core/polling/base_polling.py
Copy link
Copy Markdown
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some changes after deeper investigation

@azure-sdk
Copy link
Copy Markdown
Collaborator

API changes have been detected in azure-cosmos. You can review API changes here

Comment thread sdk/core/azure-core/azure/core/polling/base_polling.py
@azure-sdk
Copy link
Copy Markdown
Collaborator

API changes have been detected in azure-core. You can review API changes here

API changes

-     def __init__(self, operation_location_header: str = "operation-location")
+     def __init__(
+             self, 
+             operation_location_header: str = "operation-location", 
+             **kwargs
+         )

Comment thread sdk/core/azure-core/azure/core/polling/base_polling.py
@iscai-msft
Copy link
Copy Markdown
Contributor Author

/azp run python - storage - c

@azure-pipelines
Copy link
Copy Markdown

No pipelines are associated with this pull request.

@iscai-msft
Copy link
Copy Markdown
Contributor Author

/azp run python - storage - ci

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@iscai-msft
Copy link
Copy Markdown
Contributor Author

/azp run python - eventhub - ci

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@iscai-msft iscai-msft requested a review from xiangyan99 February 1, 2022 18:24
@iscai-msft
Copy link
Copy Markdown
Contributor Author

/check-enforcer override

@iscai-msft iscai-msft merged commit fba4c81 into Azure:main Feb 1, 2022
@iscai-msft iscai-msft deleted the final_state_via_core branch February 1, 2022 20:39
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants