Closed
Conversation
ghost
added
the
chlowell
requested changes
Feb 3, 2022
| dt = datetime.strptime(token["expiresOn"], "%Y-%m-%d %H:%M:%S.%f") | ||
| expires_on_in_token = token["expiresOn"] | ||
| if not expires_on_in_token: | ||
| expires_on_in_token = (datetime.now()+timedelta(days=1)).strftime("%Y-%m-%d %H:%M:%S.%f") |
Member
There was a problem hiding this comment.
The token's lifetime depends on the tenant's configuration. We don't know anything about that, so we can't safely guess when the token expires. Underestimating degrades performance; overestimating causes the auth policy to send an expired token. Really this is a CLI bug that should be fixed in the CLI. I think we have two options for handling it here:
- use the token only once (we can assume it's valid right now)
- raise AuthenticationFailedError
Option 1 makes the application terribly slow; option 2 maybe crashes it 😄
Member
|
This issue has long been fixed (Azure/azure-cli#20219). Azure CLI guarantees the existence of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#21653