Skip to content

[Storage] Support OAuth for import/export managed disks#22984

Merged
jalauzon-msft merged 9 commits intoAzure:mainfrom
jalauzon-msft:md-import-export
Feb 24, 2022
Merged

[Storage] Support OAuth for import/export managed disks#22984
jalauzon-msft merged 9 commits intoAzure:mainfrom
jalauzon-msft:md-import-export

Conversation

@jalauzon-msft
Copy link
Member

@jalauzon-msft jalauzon-msft commented Feb 9, 2022

Two changes were needed for this feature:

  • Ensure blob clients can support both OAuth and SAS together
  • Follow the bearer challenge to the correct scope from an OAuth request failure using the Storage scope

@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Feb 9, 2022
@check-enforcer
Copy link

check-enforcer bot commented Feb 9, 2022

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@jalauzon-msft jalauzon-msft marked this pull request as ready for review February 10, 2022 21:15
@jalauzon-msft
Copy link
Member Author

/azp run python - storage - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jalauzon-msft
Copy link
Member Author

/azp run python - storage - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jalauzon-msft jalauzon-msft merged commit d1ab444 into Azure:main Feb 24, 2022
@jalauzon-msft jalauzon-msft deleted the md-import-export branch February 24, 2022 20:20
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Storage Storage Service (Queues, Blobs, Files)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants