Skip to content

we renamed the file but did not update the baseline file. Fix it.#24126

Closed
xiangyan99 wants to merge 1 commit intomainfrom
secret_scan_hdinsight
Closed

we renamed the file but did not update the baseline file. Fix it.#24126
xiangyan99 wants to merge 1 commit intomainfrom
secret_scan_hdinsight

Conversation

@xiangyan99
Copy link
Member

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@xiangyan99
Copy link
Member Author

/azp run python - hdinsight - ci

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@mccoyp
Copy link
Member

mccoyp commented Apr 22, 2022

@mccoyp
Copy link
Member

mccoyp commented Apr 22, 2022

Looks like the warning is still being raised despite the name update in the baseline file. @sima-zhu, do you know why that is?

@xiangyan99 if the package owners are okay with us making a change on their behalf, could we move the fake secret that's raising the error into our fake credential store instead, and import it in the test file? We could then remove the baseline suppression entirely, which is the eventual goal anyway. We could probably name the secret value MGMT_HDINSIGHT_FAKE_KEY

@xiangyan99
Copy link
Member Author

Looks like the warning is still being raised despite the name update in the baseline file. @sima-zhu, do you know why that is?

@xiangyan99 if the package owners are okay with us making a change on their behalf, could we move the fake secret that's raising the error into our fake credential store instead, and import it in the test file? We could then remove the baseline suppression entirely, which is the eventual goal anyway. We could probably name the secret value MGMT_HDINSIGHT_FAKE_KEY

I am ok to move it into our fake cred store. But we still want to know why it failed? @sima-zhu

@sima-zhu
Copy link
Contributor

Looks like the warning is still being raised despite the name update in the baseline file. @sima-zhu, do you know why that is?
@xiangyan99 if the package owners are okay with us making a change on their behalf, could we move the fake secret that's raising the error into our fake credential store instead, and import it in the test file? We could then remove the baseline suppression entirely, which is the eventual goal anyway. We could probably name the secret value MGMT_HDINSIGHT_FAKE_KEY

I am ok to move it into our fake cred store. But we still want to know why it failed? @sima-zhu

Right, the baseline file is using hash somehow. Rename directly does not fix the error.

@sima-zhu
Copy link
Contributor

Python has guideline of fixing this. It is better to fix as @mccoyp suggested.

@xiangyan99
Copy link
Member Author

@mccoyp could you help to move those fake secrets into our fake credential store?

@xiangyan99
Copy link
Member Author

Close this one as we will use #24274 instead.

@xiangyan99 xiangyan99 closed this May 3, 2022
@xiangyan99 xiangyan99 deleted the secret_scan_hdinsight branch June 3, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants