we renamed the file but did not update the baseline file. Fix it.#24126
we renamed the file but did not update the baseline file. Fix it.#24126xiangyan99 wants to merge 1 commit intomainfrom
Conversation
|
/azp run python - hdinsight - ci |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
Looks like the warning is still being raised despite the name update in the baseline file. @sima-zhu, do you know why that is? @xiangyan99 if the package owners are okay with us making a change on their behalf, could we move the fake secret that's raising the error into our fake credential store instead, and import it in the test file? We could then remove the baseline suppression entirely, which is the eventual goal anyway. We could probably name the secret value |
I am ok to move it into our fake cred store. But we still want to know why it failed? @sima-zhu |
Right, the baseline file is using hash somehow. Rename directly does not fix the error. |
|
Python has guideline of fixing this. It is better to fix as @mccoyp suggested. |
|
@mccoyp could you help to move those fake secrets into our fake credential store? |
|
Close this one as we will use #24274 instead. |
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines