Skip to content

optimize change_log #24252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msyyc merged 7 commits into from
May 5, 2022
Merged

optimize change_log #24252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6bf5557
optimize change_log
Wzb123456789 Apr 29, 2022
01c16d8
Update change_log.py
Wzb123456789 Apr 29, 2022
7038151
Update code_report.py
Wzb123456789 Apr 29, 2022
b301895
Update code_report.py
Wzb123456789 Apr 29, 2022
bd51765
Update code_report.py
Wzb123456789 May 5, 2022
4669cf4
Update code_report.py
Wzb123456789 May 5, 2022
5d49dd3
Update code_report.py
Wzb123456789 May 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tools/azure-sdk-tools/packaging_tools/change_log.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,9 @@ def models(self, diff_entry):
self.breaking_changes.append(_MODEL_PARAM_CHANGE_REQUIRED.format(parameter_name, model_name))
return

def client(self):
self.breaking_changes.append(_CLIENT_SIGNATURE_CHANGE)
return

## Features
_ADD_OPERATION_GROUP = "Added operation group {}"
Expand All @@ -156,6 +159,7 @@ def models(self, diff_entry):
_REMOVE_OPERATION_GROUP = "Removed operation group {}"
_REMOVE_OPERATION = "Removed operation {}.{}"
_REMOVE_OPERATION_PARAM = "Operation {}.{} no longer has parameter {}"
_CLIENT_SIGNATURE_CHANGE = "Client name is changed"
_MODEL_SIGNATURE_CHANGE = "Model {} has a new signature"
_MODEL_PARAM_DELETE = "Model {} no longer has parameter {}"
_MODEL_PARAM_ADD_REQUIRED = "Model {} has a new required parameter {}"
Expand All @@ -174,6 +178,8 @@ def build_change_log(old_report, new_report):
change_log.operation(diff_line)
else:
change_log.models(diff_line)
if diff_line[0][0] == 'client':
change_log.client()

return change_log

Expand Down
8 changes: 7 additions & 1 deletion tools/azure-sdk-tools/packaging_tools/code_report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,20 @@ def parse_input(input_parameter):


def create_empty_report():
return {"models": {"enums": {}, "exceptions": {}, "models": {}}, "operations": {}}
return {"client": {}, "models": {"enums": {}, "exceptions": {}, "models": {}}, "operations": {}}


def create_report(module_name: str) -> Dict[str, Any]:
module_to_generate = importlib.import_module(module_name)
client_name = getattr(module_to_generate, '__all__')

report = create_empty_report()

try:
report["client"] = client_name
except:
report["client"] = []

# Look for models first
model_names = [model_name for model_name in dir(module_to_generate.models) if model_name[0].isupper()]
for model_name in model_names:
Expand Down