[storage.blob] Remove aiohttp as dependency for storage.blob.aio#24965
[storage.blob] Remove aiohttp as dependency for storage.blob.aio#24965
Conversation
|
API change check APIView has identified API level changes in this PR and created following API reviews. azure-eventgrid |
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
jalauzon-msft
left a comment
There was a problem hiding this comment.
Thanks for fixing this up!
sdk/storage/azure-storage-blob/azure/storage/blob/aio/_download_async.py
Show resolved
Hide resolved
…re-sdk-for-python into fix/storage-aiohttp-dependency
5ee567b to
5f340c0
Compare
vincenttran-msft
left a comment
There was a problem hiding this comment.
LGTM! Thanks for catching this and also promptly getting a PR out 😄
efcb33e to
d1d7fef
Compare
Description
aio/_download_async.pyused to importaiohttp.client_exceptions.ClientPayloadErrorto catch it if it was raised by the transport. The client should be agnostic to the transport implementation hence not import this error. Also, theAioHttpTransportResponsealready catchesaiohttp.client_exceptions.ClientPayloadErrorso this exception should never be raised by the transport.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines