Skip to content

[Storage] Fixed cspell typos in storage-datalake#25985

Merged
jalauzon-msft merged 5 commits intoAzure:mainfrom
wonhyeongseo:storage-datalake-cspell
Sep 10, 2022
Merged

[Storage] Fixed cspell typos in storage-datalake#25985
jalauzon-msft merged 5 commits intoAzure:mainfrom
wonhyeongseo:storage-datalake-cspell

Conversation

@wonhyeongseo
Copy link
Copy Markdown
Contributor

Description

fix #22677

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

* Should revert generated files
* Unify changes to _shared
@ghost ghost added Storage Storage Service (Queues, Blobs, Files) customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Sep 1, 2022
@ghost
Copy link
Copy Markdown

ghost commented Sep 1, 2022

Thank you for your contribution wonhyeongseo! We will review the pull request and get back to you soon.

@check-enforcer
Copy link
Copy Markdown

check-enforcer bot commented Sep 1, 2022

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

Copy link
Copy Markdown
Member

@jalauzon-msft jalauzon-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wonhyeongseo! Just two minor comments. Sorry for the delay getting to this review as well.

@xiangyan99 xiangyan99 added the needs-author-feedback Workflow: More information is needed from author to address the issue. label Sep 8, 2022
@wonhyeongseo
Copy link
Copy Markdown
Contributor Author

No worries, I am happy to contribute 😄

Copy link
Copy Markdown
Member

@jalauzon-msft jalauzon-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now! Thanks again @wonhyeongseo!

@jalauzon-msft jalauzon-msft merged commit 581db27 into Azure:main Sep 10, 2022
@wonhyeongseo wonhyeongseo deleted the storage-datalake-cspell branch September 10, 2022 03:32
mccoyp pushed a commit to mccoyp/azure-sdk-for-python that referenced this pull request Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-author-feedback Workflow: More information is needed from author to address the issue. Storage Storage Service (Queues, Blobs, Files)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

storage/azure-storage-file-datalake - cspell found spelling errors in source code

3 participants