Skip to content

[ServiceBus] Bug Fix: connection_verify not being passed on async#26072

Merged
3 commits merged intoAzure:mainfrom
l0lawrence:cert_servicebus
Sep 9, 2022
Merged

[ServiceBus] Bug Fix: connection_verify not being passed on async#26072
3 commits merged intoAzure:mainfrom
l0lawrence:cert_servicebus

Conversation

@l0lawrence
Copy link
Copy Markdown
Member

@l0lawrence l0lawrence commented Sep 7, 2022

It was passed through here in sync

Fixes #26015

@l0lawrence
Copy link
Copy Markdown
Member Author

/azp run python - servicebus - tests

@ghost ghost added the Service Bus label Sep 7, 2022
@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Copy Markdown
Collaborator

API change check

API changes are not detected in this pull request.

@l0lawrence l0lawrence marked this pull request as ready for review September 8, 2022 14:41
@kashifkhan
Copy link
Copy Markdown
Member

LGTM :)

Can we just add in a test to catch that exception when an invalid path is put in ?

@l0lawrence
Copy link
Copy Markdown
Member Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@ghost
Copy link
Copy Markdown

ghost commented Sep 9, 2022

Hello @l0lawrence!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Async ServiceBusClient does not respect the connection_verify parameter

3 participants