[Storage] Update typing for queue_client (Queue)#28952
Merged
vincenttran-msft merged 11 commits intoAzure:feature/storage-queue-typingfrom Mar 21, 2023
Merged
Conversation
ghost
added
the
sdk/storage/azure-storage-queue/azure/storage/queue/_queue_client.py
Outdated
Show resolved
Hide resolved
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
vincenttran-msft
changed the base branch from
main
to
feature/storage-queue-typing
sdk/storage/azure-storage-queue/azure/storage/queue/_queue_client.py
Outdated
Show resolved
Hide resolved
vincenttran-msft
requested review from
annatisch and
jalauzon-msft
as code owners
Member
jalauzon-msft
left a comment
jalauzon-msft
left a comment
There was a problem hiding this comment.
Thanks for taking this one on. Comments should all apply to async as well.
sdk/storage/azure-storage-queue/azure/storage/queue/_queue_client.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-queue/azure/storage/queue/_queue_client.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-queue/azure/storage/queue/_queue_client.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-queue/azure/storage/queue/_queue_client.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-queue/azure/storage/queue/_queue_client.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-queue/azure/storage/queue/_queue_client.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-queue/azure/storage/queue/_queue_client.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-queue/azure/storage/queue/_queue_client.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-queue/azure/storage/queue/_queue_client.py
Outdated
Show resolved
Hide resolved
...t_queue_async.pyTestAsyncStorageQueuetest_create_queue_fail_on_exist_different_metadata.json
Show resolved
Hide resolved
jalauzon-msft
approved these changes
Mar 20, 2023
Member
jalauzon-msft
left a comment
jalauzon-msft
left a comment
There was a problem hiding this comment.
Looks good! One minor comment
vincenttran-msft
added a commit
that referenced
this pull request
Nov 10, 2023
* [Storage] Update typing for `queue_service_client` (Queue) (#28949) * qsc done sync&async * Remove #type ignore, fix dict() * Fix indents * Fix indent again :D * [Storage] Update typing for `queue_client` (Queue) (#28952) * sync 80% done need *, logic * First attempt at *, * Async + unify sync spacing * Fix CI * Revert recordings * PR feedback * Revert recording, fix indents * indent, again :D * Fix content docstring * [Storage] Update typing for miscellaneous files (queue) (#29173) * [Storage] `_queue_client.py` mypy fixes (#29736) * First draft MyPy * Mypy config fix + just Config Mypy left * Fully done w/ custom StorageConfiguration * Pylint * Double import * Fix cast * PR feedback * Unused imports * Pylint * Configuration errors in async BE GONE * Fix tests that assert against _config * [Storage] _queue_client_async.py mypy fixes (#29824) * Init done for _queue_client * Fix async calling into sync * Back to the drawing board * Finished __init__ * Fix failing tests * queue_client done and decoupled * Queue specific files done * Shared, some base_client leftovers, some model leftovers * 3 _model 1 response_handlers * Mypy congrats, time to fight pylint & CI :D * unused import asyncio * New PyLint rules fixes * Pylint 2 * Fix failing test cases * Be gone test failures * Finally found root cause of infinite loop * All encryption tests passing locally, 32 pylint errors remaining * All tests passing locally, mypy green locally * Pylint * Encryption feedback done * Shared, sample, and lint output left * More comments addressed, need bc_async, policies, and samples + output * Just samples, added more helpers * More feedback * More fixes * Lint * Feedback 2 * CI * Fix weird invisible unicode char * No mypy errors hopefully no CI * Pylint and CI, but now hinting issues * Fix Lint which should fix CI * Attempted overload * Just hanging encryption and message_encoding Qs, fix import ordering * Addressed encryption feedback * Feedback, need base client decouple, need CI passing * Fixing CI * CI * CI * Ignores :( * More fixes * CI * Pylint again * Adjust typehint * Try SO workaround 41207128 * Reimport Pylint * First round of feedback * Fix CorsRule to_generated method * Fix PyLint & test failures * Feedback * Revert moving out sas token helper, causes circular dependency * Pylint * Typing feedback * Fix CI * Use QueueMessage ctor * Pylint * Privatize CorsRule method * Disable for protected access * Flip on mypy * Missed configuration value parsing * Double-spaced * Typo * Last minute nits * Extra newline in encryption
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
queue_client.pyandqueue_client_async.pyto the new typing conventions.