Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
84 commits
Select commit Hold shift + click to select a range
b32d535
[Storage] Update typing for `queue_service_client` (Queue) (#28949)
vincenttran-msft Feb 25, 2023
a804d64
Merge branch 'main' into feature/storage-queue-typing
vincenttran-msft Mar 3, 2023
7090c88
Fix indents
vincenttran-msft Mar 16, 2023
feb1fcd
Fix indent again :D
vincenttran-msft Mar 16, 2023
6b56361
[Storage] Update typing for `queue_client` (Queue) (#28952)
vincenttran-msft Mar 21, 2023
012da69
[Storage] Update typing for miscellaneous files (queue) (#29173)
vincenttran-msft Mar 29, 2023
1f4de17
Merge branch 'main' into feature/storage-queue-typing
vincenttran-msft Mar 30, 2023
c740fe1
Merge branch 'main' into feature/storage-queue-typing
vincenttran-msft Apr 7, 2023
f9290ee
[Storage] `_queue_client.py` mypy fixes (#29736)
vincenttran-msft Apr 7, 2023
b9fe687
Merge branch 'main' into feature/storage-queue-typing
vincenttran-msft Apr 28, 2023
03b65c0
[Storage] _queue_client_async.py mypy fixes (#29824)
vincenttran-msft May 3, 2023
2876b3d
Init done for _queue_client
vincenttran-msft Jun 20, 2023
c4c56be
Fix async calling into sync
vincenttran-msft Jun 21, 2023
86d626a
Back to the drawing board
vincenttran-msft Jun 22, 2023
6681a37
Finished __init__
vincenttran-msft Jun 22, 2023
16f2a4e
Fix failing tests
vincenttran-msft Jun 22, 2023
5921e48
queue_client done and decoupled
vincenttran-msft Jun 23, 2023
6aabf33
Queue specific files done
vincenttran-msft Jun 24, 2023
426a2a1
Shared, some base_client leftovers, some model leftovers
vincenttran-msft Jul 1, 2023
e15e195
3 _model 1 response_handlers
vincenttran-msft Jul 14, 2023
d8e2cf9
Merge branch 'main' into feature/storage-queue-typing
vincenttran-msft Aug 10, 2023
d925258
Mypy congrats, time to fight pylint & CI :D
vincenttran-msft Aug 10, 2023
9c3d99f
unused import asyncio
vincenttran-msft Aug 10, 2023
e00a825
New PyLint rules fixes
vincenttran-msft Aug 11, 2023
5a8409a
Pylint 2
vincenttran-msft Aug 12, 2023
f51bca9
Fix failing test cases
vincenttran-msft Aug 14, 2023
655caa7
Be gone test failures
vincenttran-msft Aug 15, 2023
8c687ea
Finally found root cause of infinite loop
vincenttran-msft Aug 16, 2023
1b304da
All encryption tests passing locally, 32 pylint errors remaining
vincenttran-msft Aug 17, 2023
774dbf2
All tests passing locally, mypy green locally
vincenttran-msft Aug 17, 2023
8a8ffad
Pylint
vincenttran-msft Aug 17, 2023
d98d2f9
Merge branch 'main' into feature/storage-queue-typing
vincenttran-msft Aug 18, 2023
12f6033
Merge branch 'main' into feature/storage-queue-typing
vincenttran-msft Aug 28, 2023
6e3f8dd
Merge branch 'main' into feature/storage-queue-typing
vincenttran-msft Aug 28, 2023
20d348d
Encryption feedback done
vincenttran-msft Aug 29, 2023
f87e1be
Shared, sample, and lint output left
vincenttran-msft Aug 30, 2023
e317e54
More comments addressed, need bc_async, policies, and samples + output
vincenttran-msft Sep 2, 2023
192b58d
Merge branch 'main' into feature/storage-queue-typing
vincenttran-msft Sep 5, 2023
512263a
Just samples, added more helpers
vincenttran-msft Sep 5, 2023
2eb11de
More feedback
vincenttran-msft Sep 7, 2023
721fc54
More fixes
vincenttran-msft Sep 7, 2023
3c6fff1
Lint
vincenttran-msft Sep 7, 2023
d82d226
Feedback 2
vincenttran-msft Sep 9, 2023
d8d9603
CI
vincenttran-msft Sep 11, 2023
3ce0c84
Fix weird invisible unicode char
vincenttran-msft Sep 12, 2023
ab30dc3
No mypy errors hopefully no CI
vincenttran-msft Sep 12, 2023
1519356
Pylint and CI, but now hinting issues
vincenttran-msft Sep 14, 2023
ed16bac
Merge branch 'main' into feature/storage-queue-typing
vincenttran-msft Sep 14, 2023
96c739e
Fix Lint which should fix CI
vincenttran-msft Sep 19, 2023
e236f2e
Attempted overload
vincenttran-msft Sep 25, 2023
fea8e48
Just hanging encryption and message_encoding Qs, fix import ordering
vincenttran-msft Sep 26, 2023
e9173f2
Addressed encryption feedback
vincenttran-msft Sep 28, 2023
0bb66d2
Feedback, need base client decouple, need CI passing
vincenttran-msft Oct 2, 2023
d100264
Fixing CI
vincenttran-msft Oct 4, 2023
0d5d67e
CI
vincenttran-msft Oct 4, 2023
0efb8bc
CI
vincenttran-msft Oct 6, 2023
f952477
Ignores :(
vincenttran-msft Oct 6, 2023
22267f7
More fixes
vincenttran-msft Oct 7, 2023
2071359
CI
vincenttran-msft Oct 9, 2023
1844459
Pylint again
vincenttran-msft Oct 9, 2023
8768e4d
Adjust typehint
vincenttran-msft Oct 10, 2023
080bea5
Try SO workaround 41207128
vincenttran-msft Oct 10, 2023
ef5e337
Merge branch 'main' into feature/storage-queue-typing
vincenttran-msft Oct 11, 2023
8fa308b
Reimport Pylint
vincenttran-msft Oct 11, 2023
509e538
First round of feedback
vincenttran-msft Oct 13, 2023
574b50c
Fix CorsRule to_generated method
vincenttran-msft Oct 13, 2023
7e90a97
Fix PyLint & test failures
vincenttran-msft Oct 13, 2023
1c21f59
Feedback
vincenttran-msft Oct 17, 2023
bb9b84a
Revert moving out sas token helper, causes circular dependency
vincenttran-msft Oct 17, 2023
d84538e
Pylint
vincenttran-msft Oct 18, 2023
de5b4eb
Typing feedback
vincenttran-msft Oct 20, 2023
4067818
Fix CI
vincenttran-msft Oct 20, 2023
519421a
Use QueueMessage ctor
vincenttran-msft Oct 20, 2023
98ac8ea
Pylint
vincenttran-msft Oct 23, 2023
542895e
Privatize CorsRule method
vincenttran-msft Oct 23, 2023
7be5de5
Disable for protected access
vincenttran-msft Oct 23, 2023
b5b0e65
Flip on mypy
vincenttran-msft Oct 26, 2023
7ba0e60
Missed configuration value parsing
vincenttran-msft Nov 1, 2023
93cb85a
Double-spaced
vincenttran-msft Nov 1, 2023
b6f4291
Typo
vincenttran-msft Nov 3, 2023
b017a74
Merge branch 'main' into feature/storage-queue-typing
vincenttran-msft Nov 10, 2023
7ae8e95
Last minute nits
vincenttran-msft Nov 10, 2023
9690d6e
Merge branch 'feature/storage-queue-typing' of https://github.com/Azu…
vincenttran-msft Nov 10, 2023
9c0d2cb
Extra newline in encryption
vincenttran-msft Nov 10, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/storage/azure-storage-queue/azure/__init__.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__path__ = __import__('pkgutil').extend_path(__path__, __name__) # type: str
__path__ = __import__('pkgutil').extend_path(__path__, __name__) # type: ignore
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__path__ = __import__('pkgutil').extend_path(__path__, __name__) # type: str
__path__ = __import__('pkgutil').extend_path(__path__, __name__) # type: ignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,22 @@
# --------------------------------------------------------------------------
# pylint: disable=unused-argument

from azure.core.exceptions import ResourceExistsError
from typing import Any, Dict, TYPE_CHECKING

from ._shared.models import StorageErrorCode
from azure.core.exceptions import ResourceExistsError
from ._models import QueueProperties
from ._shared.models import StorageErrorCode
from ._shared.response_handlers import deserialize_metadata

if TYPE_CHECKING:
from azure.core.pipeline import PipelineResponse


def deserialize_queue_properties(response, obj, headers):
def deserialize_queue_properties(
response: "PipelineResponse",
obj: Any,
headers: Dict[str, Any]
) -> QueueProperties:
metadata = deserialize_metadata(response, obj, headers)
queue_properties = QueueProperties(
metadata=metadata,
Expand All @@ -21,18 +29,22 @@ def deserialize_queue_properties(response, obj, headers):
return queue_properties


def deserialize_queue_creation(response, obj, headers):
def deserialize_queue_creation(
response: "PipelineResponse",
obj: Any,
headers: Dict[str, Any]
) -> Dict[str, Any]:
response = response.http_response
if response.status_code == 204:
if response.status_code == 204: # type: ignore
error_code = StorageErrorCode.queue_already_exists
error = ResourceExistsError(
message=(
"Queue already exists\n"
f"RequestId:{headers['x-ms-request-id']}\n"
f"Time:{headers['Date']}\n"
f"ErrorCode:{error_code}"),
response=response)
error.error_code = error_code
error.additional_info = {}
response=response) # type: ignore
error.error_code = error_code # type: ignore
error.additional_info = {} # type: ignore
raise error
return headers
Loading