Skip to content

[engsys] fix: Broken next-pylint tox environment#30526

Closed
kdestin wants to merge 1 commit intoAzure:mainfrom
kdestin:fix-next-pylint-tox-env
Closed

[engsys] fix: Broken next-pylint tox environment#30526
kdestin wants to merge 1 commit intoAzure:mainfrom
kdestin:fix-next-pylint-tox-env

Conversation

@kdestin
Copy link
Member

@kdestin kdestin commented May 24, 2023

Description

This PR is a follow up to #30159, and fixes the next-pylint tox environment which was broken by that PR

cc: @scbedd , @l0lawrence

Background

#30159 includes df6b428 which was an attempt to better document the tox environments defined in tox.ini

The commit accidentally removed the pylint== from pylint==2.15.8
(see df6b428#diff-046db483898138bdccf106f32155fe12e3658ff0dd64ff0968507e3ffe15d09bL104-R107 ), which causes installation of pylint to fail.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@kdestin kdestin requested a review from l0lawrence May 24, 2023 23:36
@kdestin
Copy link
Member Author

kdestin commented May 24, 2023

This had already been fixed by #30515

@kdestin kdestin closed this May 24, 2023
@kdestin kdestin deleted the fix-next-pylint-tox-env branch May 24, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant