Latest ARB and build fixes.#31542
Merged
bharat-kalyan-namburi merged 8 commits intocallautomation/release/beta2from Aug 9, 2023
Merged
Latest ARB and build fixes.#31542bharat-kalyan-namburi merged 8 commits intocallautomation/release/beta2from
bharat-kalyan-namburi merged 8 commits intocallautomation/release/beta2from
Conversation
This first adds a keyword argument to the TokenCredential protocol method `get_token`. This enables users and client SDKs to pass in a flag to denote that `get_token` requests should be requesting CAE tokens. If the underlying credential's `get_token` implementation supports this flag, then a CAE token will be requested. Otherwise, a non-CAE token will be requested. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com> (cherry picked from commit a7519f9)
* fix tests * update (cherry picked from commit d1d0ef6)
vivekmore-msft
requested review from
AikoBB,
LuChen-Microsoft,
RoyHerrod,
Wzb123456789,
YalinLi0312,
annatisch,
arifibrahim4,
catalinaperalta,
iscai-msft,
johanste,
kashifkhan,
kristapratico,
lmazuel,
maximrytych-ms,
mjafferi-msft,
msyyc,
tjprescott and
xiangyan99
as code owners
bharat-kalyan-namburi
approved these changes
Aug 9, 2023
bharat-kalyan-namburi
deleted the
vivekmore-msft/latest_arb_and_build_fixes
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added following changes as per ARB review