Merged
Conversation
Collaborator
|
API change check API changes are not detected in this pull request. |
29b5fe1 to
26d5366
Compare
lzchen
reviewed
Aug 28, 2023
lzchen
reviewed
Aug 28, 2023
lzchen
reviewed
Aug 28, 2023
lzchen
reviewed
Aug 28, 2023
lzchen
reviewed
Aug 28, 2023
db07ae2 to
967da35
Compare
lzchen
reviewed
Aug 28, 2023
lzchen
reviewed
Aug 28, 2023
967da35 to
111b82e
Compare
lzchen
reviewed
Sep 29, 2023
lzchen
reviewed
Sep 29, 2023
lzchen
approved these changes
Sep 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add new instrumentation_options field akin to Node's implementation. This will allow users to disable opt out supported instrumentations and enabled opt in preview instrumentations. Explicit configuration will take priority over env vars. In order to leave the door open for instrumentation configuration in the future, I have implemented a way to merge nested dictionaries. This way, a user can pass additional options and they will be merged with the defaults instead of entirely replacing them. See tests for more details.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines