Skip to content

Instrumentation options#31793

Merged
lzchen merged 7 commits intoAzure:mainfrom
jeremydvoss:instrumentation-options
Sep 29, 2023
Merged

Instrumentation options#31793
lzchen merged 7 commits intoAzure:mainfrom
jeremydvoss:instrumentation-options

Conversation

@jeremydvoss
Copy link
Copy Markdown
Member

Description

Add new instrumentation_options field akin to Node's implementation. This will allow users to disable opt out supported instrumentations and enabled opt in preview instrumentations. Explicit configuration will take priority over env vars. In order to leave the door open for instrumentation configuration in the future, I have implemented a way to merge nested dictionaries. This way, a user can pass additional options and they will be merged with the defaults instead of entirely replacing them. See tests for more details.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Copy Markdown
Collaborator

API change check

API changes are not detected in this pull request.

@jeremydvoss jeremydvoss marked this pull request as ready for review August 24, 2023 22:59
@jeremydvoss jeremydvoss requested a review from lmazuel as a code owner August 24, 2023 22:59
@jeremydvoss jeremydvoss force-pushed the instrumentation-options branch from 29b5fe1 to 26d5366 Compare August 24, 2023 23:10
@jeremydvoss jeremydvoss mentioned this pull request Aug 25, 2023
6 tasks
Comment thread sdk/monitor/azure-monitor-opentelemetry/README.md Outdated
Comment thread sdk/monitor/azure-monitor-opentelemetry/README.md Outdated
Comment thread sdk/monitor/azure-monitor-opentelemetry/README.md Outdated
Comment thread sdk/monitor/azure-monitor-opentelemetry/README.md Outdated
Comment thread sdk/monitor/azure-monitor-opentelemetry/README.md Outdated
@jeremydvoss jeremydvoss mentioned this pull request Aug 28, 2023
6 tasks
@jeremydvoss jeremydvoss force-pushed the instrumentation-options branch 2 times, most recently from db07ae2 to 967da35 Compare August 28, 2023 17:54
Comment thread sdk/monitor/azure-monitor-opentelemetry/pyproject.toml Outdated
@jeremydvoss jeremydvoss force-pushed the instrumentation-options branch from 967da35 to 111b82e Compare September 27, 2023 00:38
Comment thread sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/_constants.py Outdated
Comment thread sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/_configure.py Outdated
@lzchen lzchen merged commit 6a91dc7 into Azure:main Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants