Skip to content

pylint on #31796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jeremydvoss wants to merge 4 commits into from
Closed

pylint on #31796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aa3c9ae
pylint on
jeremydvoss Aug 24, 2023
0ad8979
changelog
jeremydvoss Aug 24, 2023
320dfc0
File encoding
jeremydvoss Aug 25, 2023
77a4d3f
no-name-in-module
jeremydvoss Aug 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sdk/monitor/azure-monitor-opentelemetry/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
([#31744](https://github.com/Azure/azure-sdk-for-python/pull/31740))
- Add preview warning for Autoinstrumentation entry points
([#31767](https://github.com/Azure/azure-sdk-for-python/pull/31767))
- Add linting back into distro
([#31796](https://github.com/Azure/azure-sdk-for-python/pull/31796))

### Breaking Changes

Expand Down
2 changes: 1 addition & 1 deletion sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/_configure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
SAMPLING_RATIO_ARG,
)
from azure.monitor.opentelemetry._types import ConfigurationValue
from azure.monitor.opentelemetry.exporter import ( # pylint: disable=import-error
from azure.monitor.opentelemetry.exporter import ( # pylint: disable=import-error,no-name-in-module
ApplicationInsightsSampler,
AzureMonitorLogExporter,
AzureMonitorMetricExporter,
Expand Down
2 changes: 1 addition & 1 deletion sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/_constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from os.path import isdir
from pathlib import Path

from azure.monitor.opentelemetry.exporter._connection_string_parser import ( # pylint: disable=import-error
from azure.monitor.opentelemetry.exporter._connection_string_parser import ( # pylint: disable=import-error,no-name-in-module
ConnectionStringParser,
)

Expand Down
4 changes: 3 additions & 1 deletion ...tor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/diagnostics/_status_logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,9 @@ def log_status(cls, agent_initialized_successfully, reason=None):
# Change to be hostname and pid
status_logger_file_name = _get_status_logger_file_name(pid)
with open(
join(_STATUS_LOG_PATH, status_logger_file_name), "w"
join(_STATUS_LOG_PATH, status_logger_file_name),
"w",
encoding="utf8"
) as f:
f.seek(0)
f.write(dumps(status_json))
Expand Down
2 changes: 1 addition & 1 deletion sdk/monitor/azure-monitor-opentelemetry/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ type_check_samples = false
verifytypes = false
pyright = false
mypy = false
pylint = false
pylint = true
bandit = false