[Key Vault] Implement abstract RSA key interfaces from cryptography#31996
Merged
Conversation
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
Member
Why not attempt to download them like I do for .NET's and Go's (unofficial) |
heaths
requested changes
Sep 12, 2023
annatisch
reviewed
Sep 12, 2023
annatisch
reviewed
Sep 12, 2023
annatisch
reviewed
Sep 12, 2023
annatisch
reviewed
Sep 12, 2023
heaths
reviewed
Sep 14, 2023
heaths
approved these changes
Sep 26, 2023
Member
heaths
left a comment
There was a problem hiding this comment.
Barring a more thorough Pythonic review, LGTM.
cryptographycryptography
annatisch
reviewed
Oct 1, 2023
schaabs
reviewed
Oct 5, 2023
annatisch
approved these changes
Oct 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #31877. This PR adds an implementation of the
cryptographylibrary's abstractRSAPrivateKeyandRSAPublicKeyinterfaces.The key implementations accept a cryptography client and key material, but are meant to be created with
create_rsa_private_keyandcreate_rsa_public_keymethods onCryptographyClient. The cryptography client is used to perform cryptographic operations (decryption and signing for private, encryption and verification for public). Byte serialization andRSAPublicKey.recover_data_from_signatureusecryptography's own implementations. Deprecated interface methods are left unimplemented.There were initial limitations to the operations we could perform because of opaque types in
cryptography. The library maintainers helped me get a fix merged, which should be available in the next release. Since we know that there will be public properties for these attributes, we can safely access private attributes that have always been present as a backup. This can be seen in the code where we inspect.algorithmand.mgfattributes.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines