Add docstring to indicate only one agent_pool_profile can be in the list#3256
Closed
WebSpider wants to merge 1 commit intoAzure:masterfrom
WebSpider:managed_cluster_docstring
Closed
Add docstring to indicate only one agent_pool_profile can be in the list#3256WebSpider wants to merge 1 commit intoAzure:masterfrom WebSpider:managed_cluster_docstring
WebSpider wants to merge 1 commit intoAzure:masterfrom
WebSpider:managed_cluster_docstring
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3256 +/- ##
=======================================
Coverage 55.2% 55.2%
=======================================
Files 9198 9198
Lines 184891 184891
=======================================
Hits 102070 102070
Misses 82821 82821
Continue to review full report at Codecov.
|
Contributor
|
Can one of the admins verify this patch? |
Member
Member
|
Yes, this is a good clarification--thanks! Only one AKS node (agent) pool is supported currently. But shouldn't we make this change here, in the Swagger spec so it propagates to all the SDKs? |
Author
|
I can pr there, no problem
|
Member
|
Yes @mboersma , it has to be done in the Swagger. But at first I wasn't even sure it was accurate :). Could you fix the Swagger and link this issue? Thanks! |
10 tasks
Member
|
Swagger PR opened at Azure/azure-rest-api-specs#3835. |
Member
|
Done in #3298 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance documentation so limit of one agent_pool_profile per managed_cluster is more clear