Remove or fix azure* environment variables in live tests#37815
Remove or fix azure* environment variables in live tests#37815benbp merged 2 commits intoAzure:mainfrom
Conversation
benbp
added
the
Central-EngSys
benbp
requested review from
ChenxiJiang333,
YalinLi0312,
iscai-msft,
kashifkhan,
kristapratico,
msyyc,
quentinRobinson,
scbedd,
weshaggard and
xiangyan99
as code owners
benbp
requested review from
a team,
annatisch,
jalauzon-msft,
lmazuel,
mccoyp,
swathipil,
vincenttran-msft and
weirongw23-msft
as code owners
|
/azp run python - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
benbp
force-pushed
the
benbp/remove-hardcode-az-sub
branch
from
656f930 to
fc7a315
Compare
|
/azp run python - keyvault - tests-weekly |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sdk/storage/tests.yml
Outdated
There was a problem hiding this comment.
Isn't this set automatically? Do we need to set it explicitly? It seems like you removed it in most other places.
There was a problem hiding this comment.
The AZURE prefix variables are not set automatically. I removed it in places where the test code has no reference to it (i.e. where it was only used for EnvironmentCredential in the past).
|
/azp run python - keyvault - tests-weekly |
|
/azp run python - storage - tests-weekly |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
test |
|
/check-enforcer evaluate |
benbp
force-pushed
the
benbp/remove-hardcode-az-sub
branch
2 times, most recently
from
2291ad7 to
e83a7a2
Compare
benbp
requested review from
FlorianBorn71,
GrahamMThomas,
Lakicar95,
chlowell,
dubiety and
yogeshmo
as code owners
benbp
force-pushed
the
benbp/remove-hardcode-az-sub
branch
from
e83a7a2 to
600efac
Compare
| ${{ insert }}: ${{ parameters.EnvVars }} | ||
| inputs: | ||
| azureSubscription: ${{ parameters.ServiceConnection }} | ||
| azureSubscription: azure-sdk-tests |
There was a problem hiding this comment.
I'm trying to retire this connection so lets prefer azure-sdk-tests-public fi these can run in TME.
There was a problem hiding this comment.
These are for the samples tests which in some cases still rely on static resources in the old subscription, same deal as with Java where we decided not to migrate for now
There was a problem hiding this comment.
I thought samples had their own arm templates if we were running them live. We should definitely be careful using static resources for testing samples as these are meant to be copy/pasted by customers.
|
API change check API changes are not detected in this pull request. |
* Remove or fix azure* environment variables in live tests * try samples against tme
3 participants
Remove or fix azure* environment variables in live tests