[Key Vault] Create Security Domain library#37929
Conversation
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
...yvault/azure-keyvault-securitydomain/azure/keyvault/securitydomain/operations/_operations.py
Outdated
Show resolved
Hide resolved
...yvault/azure-keyvault-securitydomain/azure/keyvault/securitydomain/operations/_operations.py
Outdated
Show resolved
Hide resolved
...yvault/azure-keyvault-securitydomain/azure/keyvault/securitydomain/operations/_operations.py
Outdated
Show resolved
Hide resolved
...yvault/azure-keyvault-securitydomain/azure/keyvault/securitydomain/operations/_operations.py
Outdated
Show resolved
Hide resolved
...yvault/azure-keyvault-securitydomain/azure/keyvault/securitydomain/operations/_operations.py
Outdated
Show resolved
Hide resolved
sdk/keyvault/azure-keyvault-securitydomain/azure/keyvault/securitydomain/aio/_client.py
Outdated
Show resolved
Hide resolved
98bf2c5 to
ac1bf76
Compare
sdk/keyvault/azure-keyvault-securitydomain/azure/keyvault/securitydomain/_patch.py
Show resolved
Hide resolved
|
Hi @mccoyp. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
|
@mccoyp any update of this SDK? |
|
@xuzhang3 Our current estimate is that we'd like to release an initial Python preview in early April. |
000f7af to
0e3b36c
Compare
sdk/keyvault/azure-keyvault-securitydomain/azure/keyvault/securitydomain/_client.py
Outdated
Show resolved
Hide resolved
sdk/keyvault/azure-keyvault-securitydomain/azure/keyvault/securitydomain/_client.py
Show resolved
Hide resolved
sdk/keyvault/azure-keyvault-securitydomain/azure/keyvault/securitydomain/_internal/polling.py
Outdated
Show resolved
Hide resolved
...vault/azure-keyvault-securitydomain/azure/keyvault/securitydomain/_internal/async_polling.py
Show resolved
Hide resolved
...vault/azure-keyvault-securitydomain/azure/keyvault/securitydomain/_internal/async_polling.py
Outdated
Show resolved
Hide resolved
sdk/keyvault/azure-keyvault-securitydomain/azure/keyvault/securitydomain/_patch.py
Show resolved
Hide resolved
sdk/keyvault/azure-keyvault-securitydomain/azure/keyvault/securitydomain/_patch.py
Outdated
Show resolved
Hide resolved
sdk/keyvault/azure-keyvault-securitydomain/azure/keyvault/securitydomain/_patch.py
Outdated
Show resolved
Hide resolved
pvaneck
left a comment
There was a problem hiding this comment.
Doesn't look like black, pylint, mypy, etc. are actually being run in the pipeline. I believe you need to update ci.yml in sdk/keyvault to include the new artifacts/package.
sdk/keyvault/azure-keyvault-securitydomain/azure/keyvault/securitydomain/operations/__init__.py
Outdated
Show resolved
Hide resolved
pvaneck
left a comment
There was a problem hiding this comment.
Overall, LGTM. A couple inline comments.
Also, looks like many of the analyze pipeline steps are still not checking this package because of compatibility filters filtering this package out (Python 3.9+ is required by this package, but these jobs still run on 3.8). This should be resolved with: #40499. But I trust that you've verified black/mypy/pylint/pyright are passing locally.
sdk/keyvault/azure-keyvault-securitydomain/azure/keyvault/securitydomain/_patch.py
Show resolved
Hide resolved
|
How close are we to this being in a release? Thanks |
|
Hi @p3ck, a release should be out next week, with a current date target of May 6th. |
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
pvaneck
left a comment
There was a problem hiding this comment.
Looks like test failures are from the secrets package, and it's just some mocks that need adjusting.
You might also need to adjust the aka.ms link to point to something else until the docs are generated/pushed after release to make the Analyze step green in the release pipeline.
|
/check-enforcer override |
|
/check-enforcer override |
Description
This is a new library that is mostly generated directly from TypeSpec. The goal of this library is to provide a track 2 Security Domain client for the CLI, as well as external customers. There are currently no plans for shipping this library in other languages.
Initial preview timeline: public preview release by
April 8th, 2025May 6th, 2025.Customer library request: Azure/azure-cli#29998
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines