Skip to content

[Key Vault] Create Security Domain library#37929

Merged
mccoyp merged 36 commits intoAzure:mainfrom
mccoyp:kv-securitydomain
May 3, 2025
Merged

[Key Vault] Create Security Domain library#37929
mccoyp merged 36 commits intoAzure:mainfrom
mccoyp:kv-securitydomain

Conversation

@mccoyp
Copy link
Member

@mccoyp mccoyp commented Oct 16, 2024

Description

This is a new library that is mostly generated directly from TypeSpec. The goal of this library is to provide a track 2 Security Domain client for the CLI, as well as external customers. There are currently no plans for shipping this library in other languages.

Initial preview timeline: public preview release by April 8th, 2025 May 6th, 2025.

Customer library request: Azure/azure-cli#29998

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@mccoyp mccoyp added KeyVault Client This issue points to a problem in the data-plane of the library. labels Oct 16, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 16, 2024

API Change Check

APIView identified API level changes in this PR and created the following API reviews

azure-keyvault-securitydomain

@mccoyp mccoyp force-pushed the kv-securitydomain branch from 98bf2c5 to ac1bf76 Compare October 23, 2024 06:33
@github-actions
Copy link

Hi @mccoyp. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label Jan 10, 2025
@mccoyp mccoyp removed the no-recent-activity There has been no recent activity on this issue. label Jan 10, 2025
@xuzhang3
Copy link

xuzhang3 commented Feb 6, 2025

@mccoyp any update of this SDK?

@mccoyp
Copy link
Member Author

mccoyp commented Feb 6, 2025

@xuzhang3 Our current estimate is that we'd like to release an initial Python preview in early April.

@mccoyp mccoyp force-pushed the kv-securitydomain branch from 000f7af to 0e3b36c Compare March 26, 2025 00:48
Copy link
Member

@pvaneck pvaneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like black, pylint, mypy, etc. are actually being run in the pipeline. I believe you need to update ci.yml in sdk/keyvault to include the new artifacts/package.

@mccoyp mccoyp marked this pull request as ready for review April 14, 2025 23:30
Copy link
Member

@pvaneck pvaneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM. A couple inline comments.

Also, looks like many of the analyze pipeline steps are still not checking this package because of compatibility filters filtering this package out (Python 3.9+ is required by this package, but these jobs still run on 3.8). This should be resolved with: #40499. But I trust that you've verified black/mypy/pylint/pyright are passing locally.

@p3ck
Copy link

p3ck commented Apr 29, 2025

How close are we to this being in a release? Thanks

@mccoyp
Copy link
Member Author

mccoyp commented Apr 30, 2025

Hi @p3ck, a release should be out next week, with a current date target of May 6th.

@mccoyp mccoyp force-pushed the kv-securitydomain branch from 4ae3f55 to 35823ca Compare May 2, 2025 21:22
@mccoyp mccoyp requested a review from lmazuel as a code owner May 2, 2025 21:22
@mccoyp mccoyp requested review from kristapratico and pvaneck May 2, 2025 22:00
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-keyvault-securitydomain

Copy link
Member

@pvaneck pvaneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like test failures are from the secrets package, and it's just some mocks that need adjusting.

You might also need to adjust the aka.ms link to point to something else until the docs are generated/pushed after release to make the Analyze step green in the release pipeline.

@mccoyp
Copy link
Member Author

mccoyp commented May 2, 2025

/check-enforcer override

@mccoyp
Copy link
Member Author

mccoyp commented May 3, 2025

/check-enforcer override

@mccoyp mccoyp merged commit 803cfcf into Azure:main May 3, 2025
18 of 26 checks passed
@mccoyp mccoyp deleted the kv-securitydomain branch May 3, 2025 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client This issue points to a problem in the data-plane of the library. KeyVault

Projects

None yet

Development

Successfully merging this pull request may close these issues.