Merged
Conversation
github-actions
bot
added
the
Evaluation
needuv
reviewed
Oct 23, 2024
...ai-evaluation/azure/ai/evaluation/_evaluators/_service_groundedness/_service_groundedness.py
Outdated
Show resolved
Hide resolved
needuv
reviewed
Oct 23, 2024
...ai-evaluation/azure/ai/evaluation/_evaluators/_service_groundedness/_service_groundedness.py
Outdated
Show resolved
Hide resolved
needuv
reviewed
Oct 23, 2024
...ai-evaluation/azure/ai/evaluation/_evaluators/_service_groundedness/_service_groundedness.py
Outdated
Show resolved
Hide resolved
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
…tors/_service_groundedness/_service_groundedness.py Co-authored-by: Neehar Duvvuri <40341266+needuv@users.noreply.github.com>
…tors/_service_groundedness/_service_groundedness.py Co-authored-by: Neehar Duvvuri <40341266+needuv@users.noreply.github.com>
ninghu
reviewed
Oct 24, 2024
sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_common/rai_service.py
Outdated
Show resolved
Hide resolved
ninghu
reviewed
Oct 24, 2024
sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_evaluate/_evaluate.py
Show resolved
Hide resolved
ninghu
reviewed
Oct 24, 2024
...ation/azure-ai-evaluation/azure/ai/evaluation/_evaluators/_content_safety/_content_safety.py
Show resolved
Hide resolved
ninghu
reviewed
Oct 24, 2024
...valuation/azure-ai-evaluation/azure/ai/evaluation/_evaluators/_groundedness/_groundedness.py
Show resolved
Hide resolved
ninghu
reviewed
Oct 24, 2024
sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_evaluators/_retrieval/_retrieval.py
Show resolved
Hide resolved
ninghu
reviewed
Oct 24, 2024
...ai-evaluation/azure/ai/evaluation/_evaluators/_service_groundedness/_service_groundedness.py
Show resolved
Hide resolved
ninghu
approved these changes
Oct 24, 2024
singankit
approved these changes
Oct 25, 2024
6 tasks
changliu2
reviewed
Oct 28, 2024
| result = await super()._do_eval(eval_input) | ||
| real_result = {} | ||
| real_result[self._output_prefix + "_label"] = ( | ||
| result[EvaluationMetrics.GROUNDEDNESS + "_score"] >= self._passing_score |
Member
There was a problem hiding this comment.
@MilesHolland, why do we not output the binary output as part of the AACS API? Is it because it is not part of the service call?
changliu2
reviewed
Oct 28, 2024
| azure_ai_project, | ||
| **kwargs, | ||
| ): | ||
| self._passing_score = 3 # TODO update once the binarization PR is merged |
Member
There was a problem hiding this comment.
@posaninagendra, in order to reach parity with AACS groundedness, any ungrounded content detected will make its AACS binary output ungroundedDetected to be True.
- isn't
ungroundedDetectedpart of the service call output? - if not (meaning SDK only receives
ungroundedPercentageas the output), then to match the logic for ungroudnedDetected, this self._passing_score should be 5, right?
Member
There was a problem hiding this comment.
For reference, here is the sample output on the AACS doc:
{ "ungroundedDetected": true, "ungroundedPercentage": 1, "ungroundedDetails": [ { "text": "12/hour.", "offset": { "utf8": 0, "utf16": 0, "codePoint": 0 }, "length": { "utf8": 8, "utf16": 8, "codePoint": 8 }, "reason": "None. The premise mentions a pay of \"10/hour\" but does not mention \"12/hour.\" It's neutral. " } ] }
l0lawrence
pushed a commit
to l0lawrence/azure-sdk-for-python
that referenced
this pull request
Feb 19, 2025
* Adding service based groundedness * groundedness pro eval * remove groundedness and fix unit tests * run black * change evaluate label * Update sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_evaluators/_service_groundedness/_service_groundedness.py Co-authored-by: Neehar Duvvuri <40341266+needuv@users.noreply.github.com> * Update sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_evaluators/_service_groundedness/_service_groundedness.py Co-authored-by: Neehar Duvvuri <40341266+needuv@users.noreply.github.com> * comments and CL * re record tests * black and pylint * comments * nits * analysis * re cast * more mypy appeasement --------- Co-authored-by: Ankit Singhal <anksing@microsoft.com> Co-authored-by: Neehar Duvvuri <40341266+needuv@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new service based groundedness evaluator, which uses the rai service to determine groundedness.
This has a few extra adaptations compared to a normal rai service evaluator, including:
evaluatefunction to rename the evaluator's output label to a passing score when aggregated into a metric.