(engsys) ci,fix: Fix Run Black falsely reporting success#38095
Merged
kdestin merged 2 commits intoAzure:mainfrom Oct 25, 2024
Merged
(engsys) ci,fix: Fix Run Black falsely reporting success#38095kdestin merged 2 commits intoAzure:mainfrom
Run Black falsely reporting success#38095kdestin merged 2 commits intoAzure:mainfrom
Conversation
github-actions
bot
added
the
Evaluation
kdestin
force-pushed
the
engsys/black/resolve-false-success
branch
from
add0b81 to
43a38d7
Compare
Collaborator
|
API change check API changes are not detected in this pull request. |
kdestin
force-pushed
the
engsys/black/resolve-false-success
branch
from
43a38d7 to
0685600
Compare
scbedd
reviewed
Oct 25, 2024
sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/simulator/_simulator.py
Show resolved
Hide resolved
needuv
approved these changes
Oct 25, 2024
l0lawrence
pushed a commit
to l0lawrence/azure-sdk-for-python
that referenced
this pull request
Feb 19, 2025
* ci,fix(run_black): Resolve package directory when service dir is "auto" * style: Run black
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request resolves an issue where the
Run Blackstep would falsely report success, even in situations where there were formatting violations present.Example run against a package with known formatting violations (Note that the step attempts to resolve packages in the non-existent
sdk/autoservice directory)All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines