Replace compile-time validateFormatting parameter#38212
Conversation
…validateFormatting enabled, and set that to false
l0lawrence
left a comment
There was a problem hiding this comment.
Is this going to cause CI failures if an sdk currently has black=True but ValidateFormatting False?
Yep. I'm finding the # of packages that fit in that gap (that aren't mgmt). We don't run If not...we'll see 😆 |
|
We have one of two avenues:
OR
|
I think right now black is an opt-in so I would vote for 1 to remain consistent |
Agreed, I'll make that change in this PR after making the other adjustments for opt in. |
…the parameter validateFormatting
|
API change check API changes are not detected in this pull request. |
|
/check-enforcer override Single failure to download an environment seed. |
* transition validate_formatting.py to run_black.py called from within the tox env * update filter_tox_env_string to handle check defaults that are nonTrue * default black to opt-in, not opt-out
Resolves #35153
validateFormattingparameterblackis opt-out by default, but individual packages can opt in withblack = truein theirpyproject.tomlci.ymlto remove validateFormatting and individually re-enabledblackon those packages that were running it prior to this PR.This change is necessary because of the fact that
python - pullrequestdoesn't have access to the parameter that you have set for yourci.yml. We need to emplace it some place else that's universal.I'm taking a look now because @LibbaLawrence ran into exactly this issue with
azure-eventhubrunning onpython - pullrequest.This PR moves these settings from the
validateFormattingtemplate parameter to a per-packagepyproject.toml.TODO:
validate_formatting.pyinto being called fromtoxinstead ofvalidate_formattingcalling `tox.blackcalling script withis_check_enabled.