Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
ab6096a
Initial plan for issue
Copilot May 29, 2025
35d2dc9
Add comprehensive TROUBLESHOOTING.md for Azure Service Bus
Copilot May 29, 2025
efb3b47
Replace connection string with Azure Identity credential auth in logg…
Copilot May 29, 2025
604c3e7
Update TROUBLESHOOTING.md based on PR feedback
Copilot May 30, 2025
d60ef1d
Update WebSockets example to explicitly show connection string usage
Copilot May 30, 2025
aec77c9
Update WebSockets example to use Azure Identity instead of connection…
Copilot Jun 5, 2025
03cbdbe
Add comprehensive content sections to TROUBLESHOOTING.md
Copilot Jun 5, 2025
8930ce8
Complete TROUBLESHOOTING.md with async operations and enhanced content
Copilot Jun 5, 2025
0cb1fd7
Address multiple review comments - remove sections, move sections, up…
Copilot Jun 9, 2025
e974f59
Complete review feedback implementation - remove async sections, upda…
Copilot Jun 9, 2025
b01806b
Address remaining review comments - remove unnecessary sections and r…
Copilot Jun 9, 2025
6df3eb4
Fix async example to match exact format requested in review comments
Copilot Jun 9, 2025
bafbcb2
Fix TROUBLESHOOTING.md formatting and content issues based on review …
Copilot Jun 9, 2025
6708ca5
Revert previous 5 commits as requested
Copilot Jun 9, 2025
444956c
Significantly reduce TROUBLESHOOTING.md length and focus on essential…
Copilot Jun 9, 2025
d212153
Remove sections entirely rather than condensing - address review feed…
Copilot Jun 9, 2025
a7219a5
Fix formatting issues and clean up extra blank lines
Copilot Jun 9, 2025
348f86a
Undo last 3 commits - restore TROUBLESHOOTING.md to previous state
Copilot Jun 9, 2025
a8841a3
address comments
swathipil Jun 10, 2025
1991b18
address rest of comments
swathipil Jun 10, 2025
5e40d73
fix links
swathipil Jun 10, 2025
eb640c5
Address review comments: improve retry info, fix headers, add WebSock…
Copilot Jun 10, 2025
b684064
Remove threading and concurrency section - not Service Bus specific
Copilot Jun 11, 2025
80409e2
Remove client options references from connection string troubleshooting
Copilot Jun 11, 2025
564e323
Undo changes from commits b684064e and 80409e23 - restore threading s…
Copilot Jun 11, 2025
3659814
double check Jesse's comments are addressed
swathipil Jun 11, 2025
c47c493
Merge branch 'main' into copilot/fix-169d4265-141c-4a51-a996-4696884e…
swathipil Jun 11, 2025
10714e1
apply jesses comments to other sb docs
swathipil Jun 11, 2025
e380784
libbas comments
swathipil Jun 12, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions sdk/servicebus/azure-servicebus/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,11 @@ To interact with these resources, one should be familiar with the following SDK

### Thread safety

We do not guarantee that the ServiceBusClient, ServiceBusSender, and ServiceBusReceiver are thread-safe or coroutine-safe. We do not recommend reusing these instances across threads or sharing them between coroutines. It is up to the running application to use these classes in a concurrency-safe manner.
We do not guarantee that the `ServiceBusClient`, `ServiceBusSender`, and `ServiceBusReceiver` are thread-safe or coroutine-safe. We do not recommend reusing these instances across threads or sharing them between coroutines. It is up to the running application to use these classes in a concurrency-safe manner.

The data model type, `ServiceBusMessageBatch` is not thread-safe or coroutine-safe. It should not be shared across threads nor used concurrently with client methods.

For scenarios requiring concurrent sending from multiple threads, ensure proper thread-safety management using mechanisms like threading.Lock(). **Note:** Native async APIs should be used instead of running in a ThreadPoolExecutor, if possible.
For scenarios requiring concurrent sending from multiple threads, ensure proper thread-safety management using mechanisms like `threading.Lock()`. **Note:** Native async APIs should be used instead of running in a `ThreadPoolExecutor`, if possible.
```python
import threading
from concurrent.futures import ThreadPoolExecutor
Expand Down Expand Up @@ -128,7 +128,7 @@ with client:
executor.submit(send_batch, i, sender)
```

For scenarios requiring concurrent sending in asyncio applications, ensure proper coroutine-safety management using mechanisms like asyncio.Lock()
For scenarios requiring concurrent sending in asyncio applications, ensure proper coroutine-safety management using mechanisms like `asyncio.Lock()`.
```python
import asyncio
from azure.servicebus.aio import ServiceBusClient
Expand Down
Loading