[Monitor] Generate exporter with TypeSpec by pvaneck · Pull Request #44442 · Azure/azure-sdk-for-python

pvaneck · 2025-12-16T02:18:40Z

Generation from TypeSpec from the branch in this PR: Azure/azure-rest-api-specs#38795

Noteable changes

The time field in TelemetryItem seems to have always been typed as datetime.datetime, but was being set as a ISO8601 date string. I have adjusted the tests and the _create_telemetry_item method to set the time to a datetime object and have adjusted the tests accordingly. The datetime objects will be serialized to the ISO8601 formatted strings (e.g. 2025-12-15T13:45:30.0000000Z when sent in a request anyway, so this should be fine.
In TypeSpec, defaults in models are treated as server-side defaults. The version property in the Domain model has a default of 2, however, the generated code does not include this as a default. The code was updated to explicitly set the version argument when constructing subclasses of Domain.

Notes:

Since two different TypeSpec projects are contained in this project (Exporter and LiveMetrics), I am using the batch generation feature of tsp-client where the Exporter project will be emitted into azure/monitor/opentelemetry/exporter/_generated. LiveMetrics will be emitted to azure/monitor/opentelemetry/exporter/_quickpulse/_generated in the future.
One test, tests/trace/test_trace.py::TestAzureTraceExporter::test_get_otel_resource_envelope, was failing after the regeneration. It is comparing OTel Resource attributes with MetricsData.properties, but the properties field is type and serialized as Dict[str, str]. Thus, all values end up as strings when checking the values of properties.

Asks for team

Validate whether using datetime objects instead of strings when creating TelemetryItems is acceptable.
Validate whether properties being strings inside MetricsData is acceptable.

rads-1996 · 2025-12-18T22:31:49Z

@pvaneck I can create a separate PR that runs the black format checks on the existing exporter code. I will share it once it is ready for review.

pvaneck · 2025-12-18T22:49:15Z

@rads-1996 Thanks, but I believe it was already formatted with #44462. I just need to rebase off of main.

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>

sdk/monitor/azure-monitor-opentelemetry-exporter/tests/test_base_customer_sdkstats.py

…ter subpackage

Copilot

Pull request overview

This PR migrates the Azure Monitor OpenTelemetry Exporter’s generated ingestion client/models from the legacy AutoRest output to TypeSpec (tsp-client) output, and updates the hand-written exporter code + tests to align with the new generated surface and serialization behaviors.

Changes:

Add TypeSpec batch generation configuration and record TypeSpec source metadata under _generated/.
Update exporter implementations/tests to use the new generated module path (_generated.exporter...) and to explicitly set domain schema version.
Align telemetry time handling/tests to use datetime objects (and validate properties-as-strings behavior for MetricsData.properties).

Reviewed changes

Copilot reviewed 55 out of 56 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
sdk/monitor/azure-monitor-opentelemetry-exporter/tsp-location.yaml	Adds batch generation output configuration for TypeSpec.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_generated/tsp-location.yaml	Records the TypeSpec source repo/commit metadata for the generated output.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_constants.py	Introduces `_EXPORTER_DOMAIN_SCHEMA_VERSION` used when constructing domain models.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_utils.py	Updates telemetry item creation to use `datetime` for `TelemetryItem.time` and switches generated model imports.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/export/_base.py	Updates storage deserialization/formatting for dpcodegen models and adjusts retry/drop tracking flow.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/export/trace/_exporter.py	Updates generated imports, normalizes resource properties as `Dict[str, str]`, and sets domain `version` on data models.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/export/metrics/_exporter.py	Updates generated imports and sets domain `version` on `MetricsData`.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/export/logs/_exporter.py	Updates generated imports, sets domain `version` on log data models, and adjusts tags handling for dpcodegen model semantics.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/statsbeat/customer/_utils.py	Updates generated imports to new TypeSpec-generated module path.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_manager.py	Updates generated imports to new TypeSpec-generated module path.
sdk/monitor/azure-monitor-opentelemetry-exporter/tests/trace/test_trace.py	Updates imports to new generated path; updates expectations for `datetime` envelope times; adds JSON-serialization test using `SdkJSONEncoder`; updates resource attribute expectations to stringified values.
sdk/monitor/azure-monitor-opentelemetry-exporter/tests/test_utils.py	Updates import path and adjusts `_create_telemetry_item` test to expect a `datetime` time value.
sdk/monitor/azure-monitor-opentelemetry-exporter/tests/test_base_exporter.py	Updates generated imports; aligns storage formatting tests with dpcodegen model construction; adjusts mock response behavior.
sdk/monitor/azure-monitor-opentelemetry-exporter/tests/test_base_customer_sdkstats.py	Updates generated imports; updates mock response behavior; tightens expectations for `track_dropped_items` calls.
sdk/monitor/azure-monitor-opentelemetry-exporter/tests/quickpulse/test_manager.py	Updates generated imports to new TypeSpec-generated module path.
sdk/monitor/azure-monitor-opentelemetry-exporter/tests/metrics/test_metrics.py	Updates imports and changes expected envelope `time` values to `datetime`.
sdk/monitor/azure-monitor-opentelemetry-exporter/tests/logs/test_logs.py	Updates imports, env var setup, and changes expected envelope `time` values to `datetime`.
sdk/monitor/azure-monitor-opentelemetry-exporter/tests/customer_sdk_stats/test_utlities.py	Updates generated imports to new TypeSpec-generated module path.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_generated/init.py	Repoints `_generated.AzureMonitorClient` to the new TypeSpec-generated client package.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_generated/apiview-properties.json	Adds APIView mapping metadata for the new generated surface.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_generated/_metadata.json	Adds generated metadata (e.g., apiVersion).
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_generated/operations/_azure_monitor_client_operations.py	Removes legacy AutoRest operations mixin (replaced by TypeSpec output).
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_generated/aio/operations/_azure_monitor_client_operations.py	Removes legacy AutoRest aio operations mixin (replaced by TypeSpec output).
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_generated/_azure_monitor_client.py	Removes legacy AutoRest client (replaced by TypeSpec output).
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_generated/aio/_azure_monitor_client.py	Removes legacy AutoRest async client (replaced by TypeSpec output).
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_generated/_vendor.py	Removes legacy AutoRest vendor request conversion helper.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_generated/_patch.py	Removes legacy AutoRest patch hook (replaced by new patch structure under `exporter/`).
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_generated/aio/_patch.py	Removes legacy AutoRest aio patch hook (replaced by new patch structure under `exporter/aio/`).
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_generated/models/init.py	Removes legacy AutoRest models package init (replaced by TypeSpec output).
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_generated/models/_models.py	Removes legacy AutoRest models definitions (replaced by TypeSpec output).
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_generated/models/_models_py3.py	Removes legacy AutoRest py3 models definitions (replaced by TypeSpec output).
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_generated/aio/init.py	Removes legacy AutoRest aio init (replaced by TypeSpec output).
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_generated/exporter/init.py	Adds new TypeSpec-generated synchronous client package init.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_generated/exporter/_client.py	Adds new TypeSpec-generated synchronous client implementation.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_generated/exporter/_configuration.py	Adds new TypeSpec-generated sync configuration handling (including optional credential).
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_generated/exporter/_operations/init.py	Adds new TypeSpec-generated operations package init.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_generated/exporter/_operations/_operations.py	Adds new TypeSpec-generated sync operations implementation (uses `SdkJSONEncoder`).
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_generated/exporter/_patch.py	Adds new TypeSpec-generated patch hook for sync client package.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_generated/exporter/_utils/init.py	Updates generated utils init to TypeSpec generator output.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_generated/exporter/_utils/model_base.py	Adds dpcodegen model base + `SdkJSONEncoder` used for serialization/deserialization.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_generated/exporter/_utils/utils.py	Adds dpcodegen internal typing helper for client mixins.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_generated/exporter/_version.py	Adds generated version constant for the new client package.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_generated/exporter/py.typed	Adds PEP 561 marker for the generated package.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_generated/exporter/models/init.py	Adds new TypeSpec-generated models package init.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_generated/exporter/models/_enums.py	Adds/updates generated enums (including `MonitorDomainKind` and `Versions`).
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_generated/exporter/models/_patch.py	Adds new TypeSpec-generated models patch hook.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_generated/exporter/aio/init.py	Adds new TypeSpec-generated async client package init.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_generated/exporter/aio/_client.py	Adds new TypeSpec-generated async client implementation.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_generated/exporter/aio/_configuration.py	Adds new TypeSpec-generated async configuration handling (including optional credential).
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_generated/exporter/aio/_operations/init.py	Adds new TypeSpec-generated async operations package init.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_generated/exporter/aio/_operations/_operations.py	Adds new TypeSpec-generated async operations implementation (uses `SdkJSONEncoder`).
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_generated/exporter/aio/_operations/_patch.py	Adds new TypeSpec-generated async operations patch hook.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_generated/exporter/aio/_patch.py	Adds new TypeSpec-generated async client package patch hook.

sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_utils.py

...monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/export/logs/_exporter.py

sdk/monitor/azure-monitor-opentelemetry-exporter/tests/test_base_exporter.py

...or/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/export/_base.py

...exporter/azure/monitor/opentelemetry/exporter/_generated/exporter/_operations/_operations.py

sdk/monitor/azure-monitor-opentelemetry-exporter/tests/test_base_customer_sdkstats.py

...or/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/export/_base.py

Use the merged commit hash from the specs repo and regen using an updated Python emitter version. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>

rads-1996

LGTM

* [Monitor] Generate exporter with TypeSpec Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com> * Fix resource envelope serialization for OTel resource attributes * Update tests * Update log exporter * Update * Regenerate exporter typespec models * Regenerate exporter typespec models and fix renames * Fix _generated/__init__.py to re-export AzureMonitorClient from exporter subpackage * Add trailing newline to _generated/__init__.py * Added tracing false in autogenerated code definition * Update * Update * Remove unused model imports from _base.py and fix lint * Update tsp-location.yml and regen Use the merged commit hash from the specs repo and regen using an updated Python emitter version. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com> --------- Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com> Co-authored-by: Hector Hernandez <39923391+hectorhdzg@users.noreply.github.com>

github-actions bot added the Monitor - Exporter Monitor OpenTelemetry Exporter label Dec 16, 2025

pvaneck force-pushed the monitor-otel-exporter-typespec branch from cd26a71 to b658113 Compare December 16, 2025 21:27

pvaneck force-pushed the monitor-otel-exporter-typespec branch 4 times, most recently from 8ee495f to 20fc16d Compare January 16, 2026 00:56

[Monitor] Generate exporter with TypeSpec

bc3ca46

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>

pvaneck force-pushed the monitor-otel-exporter-typespec branch from 20fc16d to bc3ca46 Compare January 17, 2026 00:22

hectorhdzg added 4 commits January 21, 2026 14:45

Fix resource envelope serialization for OTel resource attributes

9c4429e

Merge branch 'main' into monitor-otel-exporter-typespec

b00ca8a

Update tests

73ef803

Update log exporter

3687cf5

rads-1996 reviewed Jan 22, 2026

View reviewed changes

sdk/monitor/azure-monitor-opentelemetry-exporter/tests/test_base_customer_sdkstats.py Outdated Show resolved Hide resolved

hectorhdzg added 7 commits January 27, 2026 16:09

Update

f6bee73

Regenerate exporter typespec models

1614b40

Merge branch 'main' into monitor-otel-exporter-typespec

d5542b2

Merge branch 'main' into monitor-otel-exporter-typespec

44eabb4

Regenerate exporter typespec models and fix renames

5514373

Fix _generated/__init__.py to re-export AzureMonitorClient from expor…

f90dee1

…ter subpackage

Add trailing newline to _generated/__init__.py

4c6639b

hectorhdzg marked this pull request as ready for review February 6, 2026 23:17

hectorhdzg requested a review from lzchen as a code owner February 6, 2026 23:17

Copilot AI review requested due to automatic review settings February 6, 2026 23:17

hectorhdzg requested review from JacksonWeber, MSNev, hectorhdzg and jeremydvoss as code owners February 6, 2026 23:17

Copilot started reviewing on behalf of hectorhdzg February 6, 2026 23:18 View session

Copilot AI reviewed Feb 6, 2026

View reviewed changes

sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_utils.py Show resolved Hide resolved

rads-1996 reviewed Feb 9, 2026

View reviewed changes

...monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/export/logs/_exporter.py Show resolved Hide resolved

rads-1996 reviewed Feb 9, 2026

View reviewed changes

sdk/monitor/azure-monitor-opentelemetry-exporter/tests/test_base_exporter.py Outdated Show resolved Hide resolved

rads-1996 reviewed Feb 9, 2026

View reviewed changes

...or/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/export/_base.py Outdated Show resolved Hide resolved

rads-1996 reviewed Feb 11, 2026

View reviewed changes

...exporter/azure/monitor/opentelemetry/exporter/_generated/exporter/_operations/_operations.py Outdated Show resolved Hide resolved

rads-1996 reviewed Feb 12, 2026

View reviewed changes

sdk/monitor/azure-monitor-opentelemetry-exporter/tests/test_base_customer_sdkstats.py Outdated Show resolved Hide resolved

hectorhdzg added 8 commits February 12, 2026 16:13

Merge branch 'main' into monitor-otel-exporter-typespec

1e5665f

Added tracing false in autogenerated code definition

f188a43

Update

1005d4c

Update

35cff55

Merge branch 'main' into monitor-otel-exporter-typespec

b3f5730

Remove unused model imports from _base.py and fix lint

d374e2b

Merge branch 'main' into monitor-otel-exporter-typespec

dbe6e43

Merge branch 'main' into monitor-otel-exporter-typespec

fe4a1f2

rads-1996 reviewed Feb 19, 2026

View reviewed changes

...or/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/export/_base.py Show resolved Hide resolved

hectorhdzg approved these changes Feb 20, 2026

View reviewed changes

pvaneck and others added 8 commits March 3, 2026 23:51

Merge branch 'main' into monitor-otel-exporter-typespec

4531751

Update tsp-location.yml and regen

29c6a58

Use the merged commit hash from the specs repo and regen using an updated Python emitter version. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>

Merge branch 'main' into monitor-otel-exporter-typespec

b03e0d1

Merge branch 'main' into monitor-otel-exporter-typespec

face1aa

Merge branch 'main' into monitor-otel-exporter-typespec

a79bf72

Merge branch 'main' into monitor-otel-exporter-typespec

622e95d

Merge branch 'main' into monitor-otel-exporter-typespec

4a5136b

Merge branch 'main' into monitor-otel-exporter-typespec

52b5bb7

hectorhdzg approved these changes Mar 6, 2026

View reviewed changes

rads-1996 approved these changes Mar 6, 2026

View reviewed changes

hectorhdzg merged commit 5088eec into Azure:main Mar 6, 2026
20 checks passed

rads-1996 mentioned this pull request Mar 6, 2026

Exporter release 1.0.0b49 #45558

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Monitor] Generate exporter with TypeSpec#44442

[Monitor] Generate exporter with TypeSpec#44442
hectorhdzg merged 28 commits intoAzure:mainfrom
pvaneck:monitor-otel-exporter-typespec

pvaneck commented Dec 16, 2025 •

edited

Loading

Uh oh!

rads-1996 commented Dec 18, 2025

Uh oh!

pvaneck commented Dec 18, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rads-1996 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

pvaneck commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rads-1996 commented Dec 18, 2025

Uh oh!

pvaneck commented Dec 18, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rads-1996 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pvaneck commented Dec 16, 2025 •

edited

Loading