[Monitor] Generate LiveMetrics from TypeSpec by pvaneck · Pull Request #44696 · Azure/azure-sdk-for-python

pvaneck · 2026-01-16T22:25:04Z

Using SHA from Azure/azure-rest-api-specs#39699

Updated some of the filter tests as they mocked out much of the actual behavior validation.

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>

Copilot

Pull request overview

This PR migrates Quickpulse/LiveMetrics support in azure-monitor-opentelemetry-exporter to newly generated TypeSpec-based LiveMetrics client code, and updates Quickpulse internals/tests to use the new generated API surface.

Changes:

Adds TypeSpec generation configuration (tsp-location.yaml) and commits new generated livemetrics client/models under _quickpulse/_generated.
Updates Quickpulse implementation to use LiveMetricsClient and new model types (mapping-based model initialization, discriminator-based DocumentType).
Refactors Quickpulse filter tests to validate more real parsing/validation behavior and updates imports for new generated paths.

Reviewed changes

Copilot reviewed 45 out of 46 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
sdk/monitor/azure-monitor-opentelemetry-exporter/tsp-location.yaml	Adds package-level TypeSpec batch generation path for Quickpulse generated output.
sdk/monitor/azure-monitor-opentelemetry-exporter/tests/quickpulse/test_utils.py	Updates model imports and uses UTC-aware timestamps in tests.
sdk/monitor/azure-monitor-opentelemetry-exporter/tests/quickpulse/test_projection.py	Updates imports to new generated livemetrics model namespace.
sdk/monitor/azure-monitor-opentelemetry-exporter/tests/quickpulse/test_manager.py	Updates imports to new generated livemetrics model namespace.
sdk/monitor/azure-monitor-opentelemetry-exporter/tests/quickpulse/test_filter.py	Reworks filter parsing tests to validate behavior more directly; updates imports.
sdk/monitor/azure-monitor-opentelemetry-exporter/tests/quickpulse/test_exporter.py	Updates client/model imports and patch targets for the new LiveMetrics client.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_validate.py	Updates imports for validation helpers to new livemetrics model namespace.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_utils.py	Switches to new livemetrics models and adjusts document construction/type handling.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_state.py	Updates imports to new livemetrics models.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_projection.py	Updates imports to new livemetrics models.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_policy.py	Updates redirect policy typing/imports to reference `LiveMetricsClient`.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_manager.py	Updates imports to new livemetrics models.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_generated/tsp-location.yaml	Records source spec/repo/commit used for generated LiveMetrics code.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_generated/models/_patch.py	Removes legacy AutoRest-generated models patch hook.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_generated/models/_models.py	Removes legacy AutoRest-generated models.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_generated/models/init.py	Removes legacy AutoRest models package exports/init.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_generated/livemetrics/py.typed	Adds PEP 561 marker for generated livemetrics package typing.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_generated/livemetrics/models/_patch.py	Adds new generated patch hook for livemetrics models package.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_generated/livemetrics/models/_models.py	Adds new TypeSpec-generated livemetrics model implementations.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_generated/livemetrics/models/_enums.py	Adds new generated enums and adjusts docstrings/headers.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_generated/livemetrics/models/init.py	Adds new models package exports/init for livemetrics.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_generated/livemetrics/aio/_patch.py	Updates async generated patch hook to new generator style.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_generated/livemetrics/aio/_operations/_patch.py	Updates async operations patch hook to new generator style.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_generated/livemetrics/aio/_operations/_operations.py	Adds new TypeSpec-generated async operations implementation.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_generated/livemetrics/aio/_operations/init.py	Adds async operations init/patch export wiring for livemetrics.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_generated/livemetrics/aio/_configuration.py	Adds new async client configuration type for livemetrics.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_generated/livemetrics/aio/_client.py	Adds new async `LiveMetricsClient` implementation.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_generated/livemetrics/aio/init.py	Adds async package init/export wiring for livemetrics.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_generated/livemetrics/_version.py	Adds generated livemetrics package version constant.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_generated/livemetrics/_utils/utils.py	Replaces old vendor mixin typing with generic `ClientMixinABC`.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_generated/livemetrics/_utils/model_base.py	Adds generated model base/utilities used for new models/serialization.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_generated/livemetrics/_utils/init.py	Adds generated utilities package init.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_generated/livemetrics/_patch.py	Updates sync package patch hook to new generator style.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_generated/livemetrics/_operations/_patch.py	Updates sync operations patch hook to new generator style.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_generated/livemetrics/_operations/_operations.py	Adds new TypeSpec-generated sync operations implementation.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_generated/livemetrics/_operations/init.py	Adds sync operations init/patch export wiring for livemetrics.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_generated/livemetrics/_configuration.py	Adds new sync client configuration type for livemetrics.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_generated/livemetrics/_client.py	Adds new sync `LiveMetricsClient` implementation.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_generated/livemetrics/init.py	Adds sync package init/export wiring for livemetrics.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_generated/apiview-properties.json	Adds APIView metadata mappings for the generated livemetrics package.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_generated/aio/_vendor.py	Removes legacy AutoRest vendor mixin typing file for aio.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_generated/_metadata.json	Adds generation metadata (API version).
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_generated/init.py	Removes legacy generated package exports (QuickpulseClient).
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_filter.py	Updates parsing to use mapping-based model initialization from new generated models.
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_exporter.py	Switches exporter to use `LiveMetricsClient` and updated request signatures.

Comments suppressed due to low confidence (1)

sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_generated/livemetrics/_operations/_operations.py:38

This generated code uses PEP 585 built-in generics (e.g., dict[str, Any]). That will raise at import time on Python 3.8, but this package currently declares python_requires=">=3.8" in setup.py. Either adjust generation to be 3.8-compatible (e.g., via from __future__ import annotations and/or typing.Dict/typing.List in generated output), or bump the package minimum Python version to 3.9+ consistently (setup.py/classifiers/docs).

sdk/monitor/azure-monitor-opentelemetry-exporter/tests/quickpulse/test_utils.py

sdk/monitor/azure-monitor-opentelemetry-exporter/tests/quickpulse/test_exporter.py

...ter/azure/monitor/opentelemetry/exporter/_quickpulse/_generated/livemetrics/models/_patch.py

...zure/monitor/opentelemetry/exporter/_quickpulse/_generated/livemetrics/aio/_configuration.py

...ter/azure/monitor/opentelemetry/exporter/_quickpulse/_generated/livemetrics/models/_enums.py

...orter/azure/monitor/opentelemetry/exporter/_quickpulse/_generated/livemetrics/aio/_client.py

rads-1996 · 2026-02-26T20:21:48Z

We should probably add a changelog entry for this PR and the exporter one under breaking changes

hectorhdzg · 2026-02-26T22:25:46Z

@rads-1996 can you ellaborate in particular breaking changes you are seeing? these should be minimal to none ideally

rads-1996 · 2026-02-27T16:35:01Z

@rads-1996 can you ellaborate in particular breaking changes you are seeing? these should be minimal to none ideally

I was thinking in terms of classes being renamed and import paths being different now. But since we are already taking care of it in the code, we should be fine. However, in cases where the user's are importing classes or objects, whose paths have been changed, might result in import errors during startup -

In such cases, they will have to update the import paths.

hectorhdzg · 2026-02-27T22:37:11Z

@rads-1996 people should not be referencing any internal classes in our code, that is why we have init files to have public APIs that customers should be using, I will expect API review to trigger if we change any public API

rads-1996

LGTM

...-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_generated/livemetrics/_client.py

* [Monitor] Generate LiveMetrics from TypeSpec Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com> * Mypy and black updates Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com> * Updating autogenerated code to latest * Update tests --------- Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com> Co-authored-by: Hector Hernandez <39923391+hectorhdzg@users.noreply.github.com>

github-actions bot added the Monitor - Exporter Monitor OpenTelemetry Exporter label Jan 16, 2026

[Monitor] Generate LiveMetrics from TypeSpec

515bb0a

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>

pvaneck force-pushed the monitor-exporter-quickpulse-typespec branch from 0bb349e to 515bb0a Compare January 17, 2026 00:06

pvaneck and others added 4 commits January 20, 2026 19:39

Mypy and black updates

c8d8d70

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>

Merge branch 'main' into monitor-exporter-quickpulse-typespec

87894d0

Updating autogenerated code to latest

5dd792a

Merge branch 'main' into monitor-exporter-quickpulse-typespec

b46625a

hectorhdzg marked this pull request as ready for review February 24, 2026 23:49

Copilot AI review requested due to automatic review settings February 24, 2026 23:49

hectorhdzg requested review from JacksonWeber, MSNev, hectorhdzg, jeremydvoss, lzchen and rads-1996 as code owners February 24, 2026 23:49

Copilot started reviewing on behalf of hectorhdzg February 24, 2026 23:51 View session

Copilot AI reviewed Feb 24, 2026

View reviewed changes

Update tests

a62a570

rads-1996 reviewed Feb 26, 2026

View reviewed changes

...zure/monitor/opentelemetry/exporter/_quickpulse/_generated/livemetrics/aio/_configuration.py Show resolved Hide resolved

rads-1996 reviewed Feb 26, 2026

View reviewed changes

...ter/azure/monitor/opentelemetry/exporter/_quickpulse/_generated/livemetrics/models/_enums.py Show resolved Hide resolved

rads-1996 reviewed Feb 26, 2026

View reviewed changes

...orter/azure/monitor/opentelemetry/exporter/_quickpulse/_generated/livemetrics/aio/_client.py Show resolved Hide resolved

rads-1996 approved these changes Feb 27, 2026

View reviewed changes

rads-1996 reviewed Mar 3, 2026

View reviewed changes

...-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_generated/livemetrics/_client.py Show resolved Hide resolved

hectorhdzg added 3 commits March 4, 2026 13:45

Merge branch 'main' into monitor-exporter-quickpulse-typespec

729db47

Merge branch 'main' into monitor-exporter-quickpulse-typespec

75f0196

Merge branch 'main' into monitor-exporter-quickpulse-typespec

7f82294

hectorhdzg approved these changes Mar 4, 2026

View reviewed changes

hectorhdzg merged commit 2ec38cf into Azure:main Mar 4, 2026
20 checks passed

rads-1996 mentioned this pull request Mar 6, 2026

Exporter release 1.0.0b49 #45558

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Monitor] Generate LiveMetrics from TypeSpec#44696

[Monitor] Generate LiveMetrics from TypeSpec#44696
hectorhdzg merged 9 commits intoAzure:mainfrom
pvaneck:monitor-exporter-quickpulse-typespec

pvaneck commented Jan 16, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rads-1996 commented Feb 26, 2026

Uh oh!

hectorhdzg commented Feb 26, 2026

Uh oh!

rads-1996 commented Feb 27, 2026

Uh oh!

hectorhdzg commented Feb 27, 2026

Uh oh!

rads-1996 left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

pvaneck commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rads-1996 commented Feb 26, 2026

Uh oh!

hectorhdzg commented Feb 26, 2026

Uh oh!

rads-1996 commented Feb 27, 2026

Uh oh!

hectorhdzg commented Feb 27, 2026

Uh oh!

rads-1996 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pvaneck commented Jan 16, 2026 •

edited

Loading