Change import path for LoggingHandler to accommodate upstream breaking changes - Distro#45539
Merged
rads-1996 merged 9 commits intoAzure:mainfrom Mar 19, 2026
Merged
Conversation
d9397ea to
fce973b
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Azure Monitor OpenTelemetry distro to use the new LoggingHandler location from opentelemetry-instrumentation-logging, aligning with upstream deprecation/breaking changes in opentelemetry.sdk._logs.
Changes:
- Switch
LoggingHandlerimport toopentelemetry.instrumentation.logging.handler. - Update unit test module stubs to reflect the new import path.
- Bump pinned OpenTelemetry-related dependencies and add
opentelemetry-instrumentation-loggingtoinstall_requires.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/_configure.py |
Imports LoggingHandler from the instrumentation package during logging pipeline setup. |
sdk/monitor/azure-monitor-opentelemetry/tests/test_configure.py |
Adjusts sys.modules patching in logging setup tests for the new handler import. |
sdk/monitor/azure-monitor-opentelemetry/setup.py |
Updates pinned OpenTelemetry versions and adds the logging instrumentation dependency. |
sdk/monitor/azure-monitor-opentelemetry/CHANGELOG.md |
Notes the import-path change under “Other Changes”. |
You can also share your feedback on Copilot code review. Take the survey.
sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/_configure.py
Show resolved
Hide resolved
fce973b to
35aed51
Compare
4b4ec0b to
610892d
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
LoggingHandler from
opentelemetry.sdk_logsis being deprecated. Need to use theLoggingHandlerfrom theopentelemetry-instrumentation-logginginstead.All SDK Contribution checklist:
General Guidelines and Best Practices