Open
Conversation
xiangyan99
requested review from
a team,
benbp,
l0lawrence and
mccoyp
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a package-specific “agent dev skill” for azure-search-documents to guide post-TypeSpec-regeneration validation and re-application of hand-authored _patch.py customizations, and registers it in the repo-wide package skill registry.
Changes:
- Added a
search-documentsskill (SKILL.md) describing regeneration verification steps and customization patterns. - Added a
references/customizations.mdinventory of_patch.pycustomizations and their generated-code dependencies. - Updated the central
find-package-skillregistry to includeazure-search-documents.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
sdk/search/azure-search-documents/.github/skills/search-documents/references/customizations.md |
New checklist documenting each customization file’s defined symbols and regeneration verification points. |
sdk/search/azure-search-documents/.github/skills/search-documents/SKILL.md |
New skill guide for post-tsp-client update regeneration verification and customization re-checks. |
.github/skills/find-package-skill/SKILL.md |
Registers the azure-search-documents package skill in the central skill lookup table. |
sdk/search/azure-search-documents/.github/skills/azure-search-documents/SKILL.md
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
mccoyp
reviewed
Mar 28, 2026
sdk/search/azure-search-documents/.github/skills/search-documents/SKILL.md
Outdated
Show resolved
Hide resolved
samvaity
added a commit
to samvaity/azure-sdk-for-java
that referenced
this pull request
Mar 31, 2026
Add the find-package-skill discovery skill at .github/skills/, matching the pattern established in azure-sdk-for-js, azure-sdk-for-python, and azure-sdk-for-net. This skill serves as a routing table that tells AI agents to check for package-specific domain knowledge before modifying any SDK package. The package skills table is currently empty — package teams can register their skills here as they create them (e.g., azure-search-documents). Related PRs: - JS: Azure/azure-sdk-for-js#37484 - Python: Azure/azure-sdk-for-python#45972 - .NET: Azure/azure-sdk-for-net#57580 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
maorleger
added a commit
to Azure/azure-sdk-for-net
that referenced
this pull request
Mar 31, 2026
) ## What This PR adds support for **package-specific skills** — tribal knowledge that agents load before modifying SDK packages. Two files: 1. **`.github/skills/find-package-skill/SKILL.md`** — a discovery skill that teaches agents how to find package-specific skills by checking for `.github/skills/` inside the package directory they're modifying. No hardcoded lookup table — the directory structure IS the source of truth. 2. **`sdk/search/Azure.Search.Documents/.github/skills/search-documents/SKILL.md`** — placeholder skill for Search with scaffolded sections for domain experts to fill in. ## Related PRs - Azure/azure-sdk-for-js#37484 - Azure/azure-sdk-for-python#45972 ## Callouts - @efrainretana is working on the contents of the Search skill for dotnet — this placeholder provides the hook for it to be picked up correctly. - Other language repos (JS, Python) currently use a registry table approach. If directory inference works well here, we could bring it to those repos too.
mccoyp
reviewed
Apr 1, 2026
sdk/search/azure-search-documents/.github/skills/search-documents/references/customizations.md
Outdated
Show resolved
Hide resolved
sdk/search/azure-search-documents/.github/skills/search-documents/references/customizations.md
Outdated
Show resolved
Hide resolved
sdk/search/azure-search-documents/.github/skills/search-documents/SKILL.md
Outdated
Show resolved
Hide resolved
sdk/search/azure-search-documents/.github/skills/search-documents/SKILL.md
Outdated
Show resolved
Hide resolved
…nts/references/customizations.md Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add an agent dev skill for the search-documents package
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines