Implement synchronous interactive authentication#6466
Merged
chlowell merged 4 commits intoAzure:masterfrom Jul 30, 2019
Merged
Conversation
chlowell
added
Client
|
Can one of the admins verify this patch? |
Member
Author
|
/azp run python - client - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
schaabs
approved these changes
Jul 30, 2019
Member
Author
|
/azp run python - client - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6350 with a credential for synchronous interactive authentication via the authorization code flow (an async equivalent is tracked by #6451). When this credential's
get_tokenmethod is called, it opens a browser for the user to authenticate with AAD, stands up a local HTTP server and waits to receive the post-auth redirect, honoring an optional timeout. Testing this live is obviously tricky, so only offline tests are included here.