Retry decorator and livetest update#6555
Closed
yunhaoling wants to merge 15 commits intoeventhubs_preview2from
Closed
Retry decorator and livetest update#6555yunhaoling wants to merge 15 commits intoeventhubs_preview2from
yunhaoling wants to merge 15 commits intoeventhubs_preview2from
Conversation
Contributor
yunhaoling
commented
Jul 30, 2019
yunhaoling
commented
- Refactor the retry logic with decorator to improve reusability
- Add livetest for create_event_batch
* Update livetest * Remove legacy code and update livetest
|
Can one of the admins verify this patch? |
* Add missing close in livetest * Update livetest to wait longer * Close handler each time before retry
johanste
reviewed
Jul 31, 2019
sdk/eventhub/azure-eventhubs/azure/eventhub/aio/producer_async.py
Outdated
Show resolved
Hide resolved
johanste
reviewed
Aug 1, 2019
sdk/eventhub/azure-eventhubs/azure/eventhub/_consumer_producer_mixin.py
Outdated
Show resolved
Hide resolved
johanste
reviewed
Aug 1, 2019
sdk/eventhub/azure-eventhubs/azure/eventhub/_consumer_producer_mixin.py
Outdated
Show resolved
Hide resolved
johanste
reviewed
Aug 1, 2019
sdk/eventhub/azure-eventhubs/azure/eventhub/_consumer_producer_mixin.py
Outdated
Show resolved
Hide resolved
johanste
reviewed
Aug 1, 2019
sdk/eventhub/azure-eventhubs/azure/eventhub/aio/client_async.py
Outdated
Show resolved
Hide resolved
johanste
reviewed
Aug 1, 2019
sdk/eventhub/azure-eventhubs/azure/eventhub/aio/consumer_async.py
Outdated
Show resolved
Hide resolved
johanste
reviewed
Aug 1, 2019
sdk/eventhub/azure-eventhubs/azure/eventhub/aio/producer_async.py
Outdated
Show resolved
Hide resolved
johanste
reviewed
Aug 1, 2019
johanste
reviewed
Aug 1, 2019
* Wait longer for reconnect op * Raise authentication error when open timeout * Optimize retry decorator * Update code according to review * Small fix
bryevdv
reviewed
Aug 2, 2019
sdk/eventhub/azure-eventhubs/azure/eventhub/aio/consumer_async.py
Outdated
Show resolved
Hide resolved
johanste
reviewed
Aug 2, 2019
* Update decorator implementation
johanste
reviewed
Aug 3, 2019
sdk/eventhub/azure-eventhubs/azure/eventhub/_consumer_producer_mixin.py
Outdated
Show resolved
Hide resolved
johanste
reviewed
Aug 3, 2019
johanste
reviewed
Aug 3, 2019
johanste
approved these changes
Aug 3, 2019
* Draft for changelog * Improve syntax for kwargs
Contributor
Author
|
close this PR as all the changes have been merged to eventhubs_preview2 in another PR. |
bryevdv
reviewed
Aug 6, 2019
bryevdv
reviewed
Aug 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.