Conversation
|
Can one of the admins verify this patch? |
Member
Author
|
@rakshith91 - could you please sign off once you've confirm that this change resolves the tests issues in Storage (and doesn't cause any new ones!) :) |
lmazuel
approved these changes
Aug 29, 2019
rakshith91
approved these changes
Aug 29, 2019
bryevdv
approved these changes
Aug 29, 2019
Member
Author
|
@xiangyan99 is there a "preview3" branch that I should be PRing to rather than master? |
xiangyan99
approved these changes
Sep 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently aiohttp is automatically giving us a content-type header for Put/Post/Patch requests if one is not specified in the pipeline.
This behaviour is inconsistent with the requests transport.