Merged
Conversation
added 20 commits
August 22, 2019 17:54
…ython into eventhubs_preview3
YijunXieMS
added
Event Hubs
Client
YijunXieMS
requested review from
annatisch,
johanste,
kristapratico and
yunhaoling
|
Can one of the admins verify this patch? |
Contributor
Author
|
/azp run python - eventhubs - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run python - eventhubs - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run python - eventhubs - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yunhaoling
approved these changes
Aug 30, 2019
Contributor
yunhaoling
left a comment
yunhaoling
left a comment
There was a problem hiding this comment.
Just a few suggestion
overall LGTM
Contributor
Author
|
/azp run python - eventhubs - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.