Merged
Conversation
|
Can one of the admins verify this patch? |
bryevdv
approved these changes
Oct 2, 2019
daviwil
approved these changes
Oct 2, 2019
There was a problem hiding this comment.
Looks good!
This may be a place where we need to decide whether we want to be consistent between the language implementations. Both TypeScript and .NET take an authority host URI instead of just the bare host name. Only requiring the host name is definitely clearer/cleaner for users, but I wonder if leaving off the rest of the URI prefix makes it harder to mock?
Member
Author
|
I agree consistency is important, we should talk over the design. My thinking here is that the authority is the variable in the endpoints we use, so I want guardrails to steer users toward correct configuration without thinking about URLs. This doesn't complicate mocking, at least not in Python 😁 |
YijunXieMS
pushed a commit
to YijunXieMS/azure-sdk-for-python
that referenced
this pull request
Oct 9, 2019
kristapratico
pushed a commit
to rakshith91/azure-sdk-for-python
that referenced
this pull request
Oct 9, 2019
fengzhou-msft
pushed a commit
that referenced
this pull request
Nov 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5850 by accepting an
authoritykeyword argument to relevant credentials (i.e. all but the managed identity ones) and using it to construct authentication URLs.