Skip to content

[EventHubs] Preview 5#8380

Merged
yunhaoling merged 19 commits intomasterfrom
feature/eventhubs_preview5
Nov 5, 2019
Merged

[EventHubs] Preview 5#8380
yunhaoling merged 19 commits intomasterfrom
feature/eventhubs_preview5

Conversation

@lmazuel
Copy link
Member

@lmazuel lmazuel commented Nov 4, 2019

No description provided.

@yunhaoling @lmazuel
[EventHubs] Eventhubs Sync Changes (#8336)
5ab715e 
* Sync EventHub API for review

* 2.7 compatible

* new api tests

* Update sync version implemention and tests

* Making CI happy

* remove async file and add README CHANGELOG

* Update common files in eventprocessor

* Adding checkpointstoreblob

* Update unittest and share_requirement

* Update shared_requirements.txt

* Update setup.py for CI to pass

* Update storage dependency

* Update according to comment
@lmazuel lmazuel added Event Hubs Client This issue points to a problem in the data-plane of the library. labels Nov 4, 2019
@AutorestCI
Copy link
Contributor

AutorestCI commented Nov 4, 2019 •
edited
Loading

(message created by the CI based on PR content)

Installation instruction

Package azure-eventhubs-checkpointstoreblob-aio

You can install the package azure-eventhubs-checkpointstoreblob-aio of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@feature/eventhubs_preview5#egg=azure-eventhubs-checkpointstoreblob-aio&subdirectory=azure-eventhubs-checkpointstoreblob-aio"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@feature/eventhubs_preview5#egg=azure-eventhubs-checkpointstoreblob-aio&subdirectory=azure-eventhubs-checkpointstoreblob-aio"

If you have a local clone of this repository, you can also do:

  • git checkout feature/eventhubs_preview5
  • pip install -e ./azure-eventhubs-checkpointstoreblob-aio

Or build a wheel file to distribute for testing:

  • git checkout feature/eventhubs_preview5
  • pip wheel --no-deps ./azure-eventhubs-checkpointstoreblob-aio

Package azure-eventhubs-checkpointstoreblob

You can install the package azure-eventhubs-checkpointstoreblob of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@feature/eventhubs_preview5#egg=azure-eventhubs-checkpointstoreblob&subdirectory=azure-eventhubs-checkpointstoreblob"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@feature/eventhubs_preview5#egg=azure-eventhubs-checkpointstoreblob&subdirectory=azure-eventhubs-checkpointstoreblob"

If you have a local clone of this repository, you can also do:

  • git checkout feature/eventhubs_preview5
  • pip install -e ./azure-eventhubs-checkpointstoreblob

Or build a wheel file to distribute for testing:

  • git checkout feature/eventhubs_preview5
  • pip wheel --no-deps ./azure-eventhubs-checkpointstoreblob

Package azure-eventhubs

You can install the package azure-eventhubs of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@feature/eventhubs_preview5#egg=azure-eventhubs&subdirectory=azure-eventhubs"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@feature/eventhubs_preview5#egg=azure-eventhubs&subdirectory=azure-eventhubs"

If you have a local clone of this repository, you can also do:

  • git checkout feature/eventhubs_preview5
  • pip install -e ./azure-eventhubs

Or build a wheel file to distribute for testing:

  • git checkout feature/eventhubs_preview5
  • pip wheel --no-deps ./azure-eventhubs

Direct download

Your files can be directly downloaded here:

@YijunXieMS @lmazuel
[EventHubs] Eventhubs aio changes (#8331)
8403743 
* Eventhubs AIO changes

* Add new files

* Add new files

* Add test code for review

* Changes for code review

* Make it testable

* Update conftest for backward compatibility

* add init to _eventprocessor

* Remove obsolete async test example

* Remove sample partition manager

* update blobstorageaio

* Put close reason and ownership error to common

* Add blobstorage stuffs

* fix pylint

* Fix shared_requirement

* Change blob storage dependency to >=12.0.0

* small doc change
@lmazuel lmazuel marked this pull request as ready for review November 4, 2019 22:47
@lmazuel lmazuel requested a review from mitchdenny as a code owner November 4, 2019 22:47
lmazuel
lmazuel commented Nov 5, 2019
View reviewed changes
Copy link
Member Author

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few packaging update to do

sdk/eventhub/azure-eventhubs-checkpointstoreblob-aio/README.md
### Documentation

Reference documentation is available at https://azure.github.io/azure-sdk-for-python/ref/azure.eventhub.extensions.html.
Reference documentation is available at https://azuresdkdocs.blob.core.windows.net/$web/python/azure-eventhub/5.0.0b5/azure.eventhub.extensions.html
Copy link
Member Author

@lmazuel lmazuel Nov 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extensions being empty, this link will not exits. What do you wanted to show here?

Copy link
Contributor

@yunhaoling yunhaoling Nov 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the link , pointing to the PartitionManager in eventhub docs

Copy link
Member Author

@lmazuel lmazuel Nov 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still don't see the link updated in the PR?

Copy link
Contributor

@yunhaoling yunhaoling Nov 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's due to the github that can't show the changes.

I checked files in the branch and see the links are up to date.

README of azure-eventhubs-checkpointstoreblob

README of azure-eventhubs-checkpointstoreblob-aio

sdk/eventhub/azure-eventhubs/HISTORY.md Outdated

**Breaking changes**

- `EventHubClient` has been split into two separate clients: `EventHubProducerClient` and `EventHubConsumerClient`.
Copy link
Member Author

@lmazuel lmazuel Nov 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mention all the module which are not plublic anymore (see release note of azure-core 1.0.0b4 for example)

Copy link
Contributor

@yunhaoling yunhaoling Nov 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have only removed EventHubClient, EventHubProducerClient, EventHubConsumerClient.

Copy link
Member Author

@lmazuel lmazuel Nov 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, you also removed "azure.eventhub.common", "azure.eventhub.client_abstract", etc. every modules that are not available anymore. I know the code is still available, but we don't document them so they should be written as "removed"

Copy link
Contributor

@yunhaoling yunhaoling Nov 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, I've updated the changelog.

lmazuel and others added 7 commits November 4, 2019 16:47
@lmazuel
Doc improvement
bf1fe71
@yunhaoling
[EventHubs] Updating samples, small update in readme (#8383)
6701399 
* Updating samples, small update in readme

* Small update on blob storage sample

* Update readme to fix analyze check

* remove timeout and retry in sample

* fix pylint and update rst

* remove timeout and retry in sample
Remove CloseReason from aio init
6f9c094
Update docstring
ae2e61a
Hide static keys of EventData
b2f0afd
Merge branch 'feature/eventhubs_preview5' of github.com:Azure/azure-s…
f226bed 
…dk-for-python into feature/eventhubs_preview5
@yunhaoling
Update from connection string and test.yml (#8392)
3af58d0 
* update env name in yml

* update from connection string

* small fix
@yunhaoling
Copy link
Contributor

yunhaoling commented Nov 5, 2019

/azp run python - eventhubs - tests

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 5, 2019

Azure Pipelines successfully started running 1 pipeline(s).

yijxie and others added 3 commits November 4, 2019 22:32
Update docstring
b5daa3a
Fix a test file problem after merge async/sync
509ee81
@yunhaoling
Docstring, sample, readme update (#8395)
eddfe5c 
* update env name in yml

* update from connection string

* small fix

* Update manifest files, samples, code snippet

* Fix in docstring

* update readme

* Small fix

* remove unused import
@YijunXieMS
Copy link
Contributor

YijunXieMS commented Nov 5, 2019 •
edited
Loading

/azp run python - eventhubs - tests

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 5, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 5, 2019

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

azure-pipelines bot commented Nov 5, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@YijunXieMS
Copy link
Contributor

YijunXieMS commented Nov 5, 2019

/azp run python - eventhubs - tests

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 5, 2019

Azure Pipelines successfully started running 1 pipeline(s).

2 similar comments
@azure-pipelines
Copy link

azure-pipelines bot commented Nov 5, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 5, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@yunhaoling
Changelog, sample, test updates (#8411)
370a83e 
* doc feedback update

* update on changelog and samples

* small fix in samples
@yunhaoling
Copy link
Contributor

yunhaoling commented Nov 5, 2019

/azp run python - eventhubs - tests

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 5, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@yunhaoling
Copy link
Contributor

yunhaoling commented Nov 5, 2019

/azp run python - eventhubs - tests

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 5, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@yunhaoling
Copy link
Contributor

yunhaoling commented Nov 5, 2019

/azp run python - eventhubs - tests

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 5, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@yunhaoling
Copy link
Contributor

yunhaoling commented Nov 5, 2019

/azp run python - eventhubs - tests

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 5, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@lmazuel lmazuel requested review from johanste and removed request for danieljurek, mitchdenny, scbedd and weshaggard November 5, 2019 19:52
@yunhaoling yunhaoling merged commit a6340bd into master Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@annatisch annatisch annatisch approved these changes

@yunhaoling yunhaoling Awaiting requested review from yunhaoling

@YijunXieMS YijunXieMS Awaiting requested review from YijunXieMS

@johanste johanste Awaiting requested review from johanste

Assignees

No one assigned

Labels

Client This issue points to a problem in the data-plane of the library. Event Hubs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lmazuel @AutorestCI @yunhaoling @YijunXieMS @annatisch