Fix a wrong usage of gemspec usage, relax nokogiri & faraday_middleware requirement#182
Open
jasl wants to merge 1 commit intoAzure:masterfrom
Open
Fix a wrong usage of gemspec usage, relax nokogiri & faraday_middleware requirement#182jasl wants to merge 1 commit intoAzure:masterfrom
jasl wants to merge 1 commit intoAzure:masterfrom
Conversation
Author
|
BTW, if the PR merged, could you release a new version? |
nertzy
approved these changes
Sep 9, 2021
nertzy
left a comment
There was a problem hiding this comment.
Looks good to me. This is more in line with standard Ruby expectations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my experience, this usage maybe wrong
azure-storage-blobdepends onnokogiri ~> 1.11.0.rc2~> 1.10is enough for all versions of Rubies, the bundler can find the best match versionI found this because sparklemotion/nokogiri#2168 (comment)
In addition
I also relex
faraday_middleware