Resolve dependency issue for Nokogiri/Faraday#206
Conversation
|
Please do share your input especially if you are on the earlier versions of Ruby (below 2.5). |
|
This looks good to me. |
nertzy
left a comment
nertzy
left a comment
There was a problem hiding this comment.
I think this is a good balance between enforcing a minimum version and allowing users to upgrade to any 1.x version.
|
This looks fine to me, thanks for the prompt response @katmsft. |
|
LGTM |
|
LGTM - we need this too to address nokogiri vulnerabilities. |
lindsaymkelly
left a comment
lindsaymkelly
left a comment
There was a problem hiding this comment.
LGTM - hoping this ships soon to address nokogiri vulnerabilities 🤞
|
Please reference this issue for a workaround if you have trouble using the gems: #196 |
|
Excited to have this resolved! I also need to address the nokogiri vulnerabilties. Thanks! |
|
Since I'm not seeing any downvotes for this PR, I'll proceed and merge it and push for a release. Thanks for your feedback. |
10 participants
No description provided.