Handle types in first and last functions#9533
Merged
jeskew merged 12 commits intoAzure:mainfrom Jan 23, 2023
levimatheri:fix/issue-9471-first-function-dot-notation
Merged
Handle types in first and last functions#9533jeskew merged 12 commits intoAzure:mainfrom levimatheri:fix/issue-9471-first-function-dot-notation
first and last functions#9533jeskew merged 12 commits intoAzure:mainfrom
levimatheri:fix/issue-9471-first-function-dot-notation
Conversation
jeskew
reviewed
Jan 17, 2023
Contributor
jeskew
left a comment
jeskew
left a comment
There was a problem hiding this comment.
Thanks for taking this on, @levimatheri (and for adding last to the mix as well)!
I had a couple comments stemming from the TupleType changes that are in main but have not yet been included in a release.
jeskew
reviewed
Jan 20, 2023
Contributor
jeskew
left a comment
jeskew
left a comment
There was a problem hiding this comment.
The test failures look like type errors caused by first and last no longer using a return type of any. All the ones I saw could be fixed by the ! operator added in #9585 (e.g., change first(first(privateEndpoint.properties.customDnsConfigs).ipAddresses) to first(first(privateEndpoint.properties.customDnsConfigs)!.ipAddresses)! on this line). If that doesn't work in any cases, you can use the any function.
Once those are fixed, this PR will be good to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9471.
FYI @jeskew
Microsoft Reviewers: Open in CodeFlow