Skip to content

Use schema $ref resolution from ARM template engine in ArmTemplateSemanticModel #9621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeskew merged 5 commits into from
Jan 23, 2023
Merged

Use schema $ref resolution from ARM template engine in ArmTemplateSemanticModel #9621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
84d8c55
Spin off a small refactor from https://github.com/Azure/bicep/pull/9454
jeskew Jan 23, 2023
5fb9370
Update src/Bicep.Core/Diagnostics/DiagnosticBuilder.cs
jeskew Jan 23, 2023
bc56f45
Incorporate PR feedback
jeskew Jan 23, 2023
2b3de4b
Merge branch 'main' into jeskew/$ref-fixup
jeskew Jan 23, 2023
138c054
Merge branch 'main' into jeskew/$ref-fixup
jeskew Jan 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions src/Bicep.Cli.IntegrationTests/packages.lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,8 @@
},
"Azure.Deployments.Core": {
"type": "Transitive",
"resolved": "1.0.788",
"contentHash": "7sK2ff4cDx9Ham/4DnbpZ2HL9cwnqEMsW8fWqM20dh9xoCTv8g2EGTw7MSMTHSJvqjJVSce+mEr6ldJfpfsDMA==",
"resolved": "1.0.815",
"contentHash": "vY5jCUjlm0xLGd/losAWT7w9NsL99WydtJ2ms5DmGcS6mmNmYdUedf4JiCHjTqU8OG+5niOi2BBTtLqTV7u4iw==",
"dependencies": {
"Microsoft.PowerPlatform.ResourceStack": "6.0.0.1423",
"Newtonsoft.Json": "13.0.1",
Expand All @@ -121,20 +121,20 @@
},
"Azure.Deployments.Expression": {
"type": "Transitive",
"resolved": "1.0.788",
"contentHash": "NWQygy/uUMYQB8JXP1CnorMs9J/zkszEk+nk3dAjAHDFjBbj8potaDyv1vq9E+KiUSvR5NFXHc1YVOvTBdLZ/Q==",
"resolved": "1.0.815",
"contentHash": "hZwwN96E02EKlm0u6zD53jr69nuJOdN3rTp/9ZjV6x+2OjW5ixofx17Z2pWU8qFmH82dy42PgYBysDhppw5GGA==",
"dependencies": {
"Azure.Deployments.Core": "1.0.788",
"Azure.Deployments.Core": "1.0.815",
"Newtonsoft.Json": "13.0.1"
}
},
"Azure.Deployments.Templates": {
"type": "Transitive",
"resolved": "1.0.788",
"contentHash": "PuTc4Sq67xIi4Apu/v0CsIpzLBr43B+V231aLPlurCHJStir/BZGPPYDh+sXvpY/+zcMWn1j6A74Rv2Isrtr5A==",
"resolved": "1.0.815",
"contentHash": "c0d9o56MzPiTjGtAsXjOOnHh7FlVlb9BAMci9os1ET+mkkBRw0C0l6QlEzve/w62iHt9nD4hYD43YP4/g7gU0Q==",
"dependencies": {
"Azure.Deployments.Core": "1.0.788",
"Azure.Deployments.Expression": "1.0.788",
"Azure.Deployments.Core": "1.0.815",
"Azure.Deployments.Expression": "1.0.815",
"Newtonsoft.Json": "13.0.1"
}
},
Expand Down Expand Up @@ -1979,9 +1979,9 @@
"Azure.Bicep.Types.Az": "[0.2.238, )",
"Azure.Bicep.Types.K8s": "[0.1.233, )",
"Azure.Containers.ContainerRegistry": "[1.1.0-beta.4, )",
"Azure.Deployments.Core": "[1.0.788, )",
"Azure.Deployments.Expression": "[1.0.788, )",
"Azure.Deployments.Templates": "[1.0.788, )",
"Azure.Deployments.Core": "[1.0.815, )",
"Azure.Deployments.Expression": "[1.0.815, )",
"Azure.Deployments.Templates": "[1.0.815, )",
"Azure.Identity": "[1.8.1, )",
"Azure.ResourceManager.Resources": "[1.3.1, )",
"JsonPatch.Net": "[2.0.4, )",
Expand Down
24 changes: 12 additions & 12 deletions src/Bicep.Cli.UnitTests/packages.lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,8 @@
},
"Azure.Deployments.Core": {
"type": "Transitive",
"resolved": "1.0.788",
"contentHash": "7sK2ff4cDx9Ham/4DnbpZ2HL9cwnqEMsW8fWqM20dh9xoCTv8g2EGTw7MSMTHSJvqjJVSce+mEr6ldJfpfsDMA==",
"resolved": "1.0.815",
"contentHash": "vY5jCUjlm0xLGd/losAWT7w9NsL99WydtJ2ms5DmGcS6mmNmYdUedf4JiCHjTqU8OG+5niOi2BBTtLqTV7u4iw==",
"dependencies": {
"Microsoft.PowerPlatform.ResourceStack": "6.0.0.1423",
"Newtonsoft.Json": "13.0.1",
Expand All @@ -121,20 +121,20 @@
},
"Azure.Deployments.Expression": {
"type": "Transitive",
"resolved": "1.0.788",
"contentHash": "NWQygy/uUMYQB8JXP1CnorMs9J/zkszEk+nk3dAjAHDFjBbj8potaDyv1vq9E+KiUSvR5NFXHc1YVOvTBdLZ/Q==",
"resolved": "1.0.815",
"contentHash": "hZwwN96E02EKlm0u6zD53jr69nuJOdN3rTp/9ZjV6x+2OjW5ixofx17Z2pWU8qFmH82dy42PgYBysDhppw5GGA==",
"dependencies": {
"Azure.Deployments.Core": "1.0.788",
"Azure.Deployments.Core": "1.0.815",
"Newtonsoft.Json": "13.0.1"
}
},
"Azure.Deployments.Templates": {
"type": "Transitive",
"resolved": "1.0.788",
"contentHash": "PuTc4Sq67xIi4Apu/v0CsIpzLBr43B+V231aLPlurCHJStir/BZGPPYDh+sXvpY/+zcMWn1j6A74Rv2Isrtr5A==",
"resolved": "1.0.815",
"contentHash": "c0d9o56MzPiTjGtAsXjOOnHh7FlVlb9BAMci9os1ET+mkkBRw0C0l6QlEzve/w62iHt9nD4hYD43YP4/g7gU0Q==",
"dependencies": {
"Azure.Deployments.Core": "1.0.788",
"Azure.Deployments.Expression": "1.0.788",
"Azure.Deployments.Core": "1.0.815",
"Azure.Deployments.Expression": "1.0.815",
"Newtonsoft.Json": "13.0.1"
}
},
Expand Down Expand Up @@ -1805,9 +1805,9 @@
"Azure.Bicep.Types.Az": "[0.2.238, )",
"Azure.Bicep.Types.K8s": "[0.1.233, )",
"Azure.Containers.ContainerRegistry": "[1.1.0-beta.4, )",
"Azure.Deployments.Core": "[1.0.788, )",
"Azure.Deployments.Expression": "[1.0.788, )",
"Azure.Deployments.Templates": "[1.0.788, )",
"Azure.Deployments.Core": "[1.0.815, )",
"Azure.Deployments.Expression": "[1.0.815, )",
"Azure.Deployments.Templates": "[1.0.815, )",
"Azure.Identity": "[1.8.1, )",
"Azure.ResourceManager.Resources": "[1.3.1, )",
"JsonPatch.Net": "[2.0.4, )",
Expand Down
24 changes: 12 additions & 12 deletions src/Bicep.Cli/packages.lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,8 @@
},
"Azure.Deployments.Core": {
"type": "Transitive",
"resolved": "1.0.788",
"contentHash": "7sK2ff4cDx9Ham/4DnbpZ2HL9cwnqEMsW8fWqM20dh9xoCTv8g2EGTw7MSMTHSJvqjJVSce+mEr6ldJfpfsDMA==",
"resolved": "1.0.815",
"contentHash": "vY5jCUjlm0xLGd/losAWT7w9NsL99WydtJ2ms5DmGcS6mmNmYdUedf4JiCHjTqU8OG+5niOi2BBTtLqTV7u4iw==",
"dependencies": {
"Microsoft.PowerPlatform.ResourceStack": "6.0.0.1423",
"Newtonsoft.Json": "13.0.1",
Expand All @@ -102,20 +102,20 @@
},
"Azure.Deployments.Expression": {
"type": "Transitive",
"resolved": "1.0.788",
"contentHash": "NWQygy/uUMYQB8JXP1CnorMs9J/zkszEk+nk3dAjAHDFjBbj8potaDyv1vq9E+KiUSvR5NFXHc1YVOvTBdLZ/Q==",
"resolved": "1.0.815",
"contentHash": "hZwwN96E02EKlm0u6zD53jr69nuJOdN3rTp/9ZjV6x+2OjW5ixofx17Z2pWU8qFmH82dy42PgYBysDhppw5GGA==",
"dependencies": {
"Azure.Deployments.Core": "1.0.788",
"Azure.Deployments.Core": "1.0.815",
"Newtonsoft.Json": "13.0.1"
}
},
"Azure.Deployments.Templates": {
"type": "Transitive",
"resolved": "1.0.788",
"contentHash": "PuTc4Sq67xIi4Apu/v0CsIpzLBr43B+V231aLPlurCHJStir/BZGPPYDh+sXvpY/+zcMWn1j6A74Rv2Isrtr5A==",
"resolved": "1.0.815",
"contentHash": "c0d9o56MzPiTjGtAsXjOOnHh7FlVlb9BAMci9os1ET+mkkBRw0C0l6QlEzve/w62iHt9nD4hYD43YP4/g7gU0Q==",
"dependencies": {
"Azure.Deployments.Core": "1.0.788",
"Azure.Deployments.Expression": "1.0.788",
"Azure.Deployments.Core": "1.0.815",
"Azure.Deployments.Expression": "1.0.815",
"Newtonsoft.Json": "13.0.1"
}
},
Expand Down Expand Up @@ -1742,9 +1742,9 @@
"Azure.Bicep.Types.Az": "[0.2.238, )",
"Azure.Bicep.Types.K8s": "[0.1.233, )",
"Azure.Containers.ContainerRegistry": "[1.1.0-beta.4, )",
"Azure.Deployments.Core": "[1.0.788, )",
"Azure.Deployments.Expression": "[1.0.788, )",
"Azure.Deployments.Templates": "[1.0.788, )",
"Azure.Deployments.Core": "[1.0.815, )",
"Azure.Deployments.Expression": "[1.0.815, )",
"Azure.Deployments.Templates": "[1.0.815, )",
"Azure.Identity": "[1.8.1, )",
"Azure.ResourceManager.Resources": "[1.3.1, )",
"JsonPatch.Net": "[2.0.4, )",
Expand Down
24 changes: 12 additions & 12 deletions src/Bicep.Core.IntegrationTests/packages.lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,8 @@
},
"Azure.Deployments.Core": {
"type": "Transitive",
"resolved": "1.0.788",
"contentHash": "7sK2ff4cDx9Ham/4DnbpZ2HL9cwnqEMsW8fWqM20dh9xoCTv8g2EGTw7MSMTHSJvqjJVSce+mEr6ldJfpfsDMA==",
"resolved": "1.0.815",
"contentHash": "vY5jCUjlm0xLGd/losAWT7w9NsL99WydtJ2ms5DmGcS6mmNmYdUedf4JiCHjTqU8OG+5niOi2BBTtLqTV7u4iw==",
"dependencies": {
"Microsoft.PowerPlatform.ResourceStack": "6.0.0.1423",
"Newtonsoft.Json": "13.0.1",
Expand All @@ -121,20 +121,20 @@
},
"Azure.Deployments.Expression": {
"type": "Transitive",
"resolved": "1.0.788",
"contentHash": "NWQygy/uUMYQB8JXP1CnorMs9J/zkszEk+nk3dAjAHDFjBbj8potaDyv1vq9E+KiUSvR5NFXHc1YVOvTBdLZ/Q==",
"resolved": "1.0.815",
"contentHash": "hZwwN96E02EKlm0u6zD53jr69nuJOdN3rTp/9ZjV6x+2OjW5ixofx17Z2pWU8qFmH82dy42PgYBysDhppw5GGA==",
"dependencies": {
"Azure.Deployments.Core": "1.0.788",
"Azure.Deployments.Core": "1.0.815",
"Newtonsoft.Json": "13.0.1"
}
},
"Azure.Deployments.Templates": {
"type": "Transitive",
"resolved": "1.0.788",
"contentHash": "PuTc4Sq67xIi4Apu/v0CsIpzLBr43B+V231aLPlurCHJStir/BZGPPYDh+sXvpY/+zcMWn1j6A74Rv2Isrtr5A==",
"resolved": "1.0.815",
"contentHash": "c0d9o56MzPiTjGtAsXjOOnHh7FlVlb9BAMci9os1ET+mkkBRw0C0l6QlEzve/w62iHt9nD4hYD43YP4/g7gU0Q==",
"dependencies": {
"Azure.Deployments.Core": "1.0.788",
"Azure.Deployments.Expression": "1.0.788",
"Azure.Deployments.Core": "1.0.815",
"Azure.Deployments.Expression": "1.0.815",
"Newtonsoft.Json": "13.0.1"
}
},
Expand Down Expand Up @@ -1979,9 +1979,9 @@
"Azure.Bicep.Types.Az": "[0.2.238, )",
"Azure.Bicep.Types.K8s": "[0.1.233, )",
"Azure.Containers.ContainerRegistry": "[1.1.0-beta.4, )",
"Azure.Deployments.Core": "[1.0.788, )",
"Azure.Deployments.Expression": "[1.0.788, )",
"Azure.Deployments.Templates": "[1.0.788, )",
"Azure.Deployments.Core": "[1.0.815, )",
"Azure.Deployments.Expression": "[1.0.815, )",
"Azure.Deployments.Templates": "[1.0.815, )",
"Azure.Identity": "[1.8.1, )",
"Azure.ResourceManager.Resources": "[1.3.1, )",
"JsonPatch.Net": "[2.0.4, )",
Expand Down
24 changes: 12 additions & 12 deletions src/Bicep.Core.Samples/packages.lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,8 @@
},
"Azure.Deployments.Core": {
"type": "Transitive",
"resolved": "1.0.788",
"contentHash": "7sK2ff4cDx9Ham/4DnbpZ2HL9cwnqEMsW8fWqM20dh9xoCTv8g2EGTw7MSMTHSJvqjJVSce+mEr6ldJfpfsDMA==",
"resolved": "1.0.815",
"contentHash": "vY5jCUjlm0xLGd/losAWT7w9NsL99WydtJ2ms5DmGcS6mmNmYdUedf4JiCHjTqU8OG+5niOi2BBTtLqTV7u4iw==",
"dependencies": {
"Microsoft.PowerPlatform.ResourceStack": "6.0.0.1423",
"Newtonsoft.Json": "13.0.1",
Expand All @@ -121,20 +121,20 @@
},
"Azure.Deployments.Expression": {
"type": "Transitive",
"resolved": "1.0.788",
"contentHash": "NWQygy/uUMYQB8JXP1CnorMs9J/zkszEk+nk3dAjAHDFjBbj8potaDyv1vq9E+KiUSvR5NFXHc1YVOvTBdLZ/Q==",
"resolved": "1.0.815",
"contentHash": "hZwwN96E02EKlm0u6zD53jr69nuJOdN3rTp/9ZjV6x+2OjW5ixofx17Z2pWU8qFmH82dy42PgYBysDhppw5GGA==",
"dependencies": {
"Azure.Deployments.Core": "1.0.788",
"Azure.Deployments.Core": "1.0.815",
"Newtonsoft.Json": "13.0.1"
}
},
"Azure.Deployments.Templates": {
"type": "Transitive",
"resolved": "1.0.788",
"contentHash": "PuTc4Sq67xIi4Apu/v0CsIpzLBr43B+V231aLPlurCHJStir/BZGPPYDh+sXvpY/+zcMWn1j6A74Rv2Isrtr5A==",
"resolved": "1.0.815",
"contentHash": "c0d9o56MzPiTjGtAsXjOOnHh7FlVlb9BAMci9os1ET+mkkBRw0C0l6QlEzve/w62iHt9nD4hYD43YP4/g7gU0Q==",
"dependencies": {
"Azure.Deployments.Core": "1.0.788",
"Azure.Deployments.Expression": "1.0.788",
"Azure.Deployments.Core": "1.0.815",
"Azure.Deployments.Expression": "1.0.815",
"Newtonsoft.Json": "13.0.1"
}
},
Expand Down Expand Up @@ -1979,9 +1979,9 @@
"Azure.Bicep.Types.Az": "[0.2.238, )",
"Azure.Bicep.Types.K8s": "[0.1.233, )",
"Azure.Containers.ContainerRegistry": "[1.1.0-beta.4, )",
"Azure.Deployments.Core": "[1.0.788, )",
"Azure.Deployments.Expression": "[1.0.788, )",
"Azure.Deployments.Templates": "[1.0.788, )",
"Azure.Deployments.Core": "[1.0.815, )",
"Azure.Deployments.Expression": "[1.0.815, )",
"Azure.Deployments.Templates": "[1.0.815, )",
"Azure.Identity": "[1.8.1, )",
"Azure.ResourceManager.Resources": "[1.3.1, )",
"JsonPatch.Net": "[2.0.4, )",
Expand Down
5 changes: 5 additions & 0 deletions src/Bicep.Core.UnitTests/Semantics/ArmTemplateSemanticModelTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.

using System.Linq;
using Bicep.Core.Semantics;
using Bicep.Core.TypeSystem;
using Bicep.Core.Workspaces;
Expand Down Expand Up @@ -213,6 +214,7 @@ public void Model_handles_missing_type_reference_targets()
""$schema"": ""https://schema.management.azure.com/schemas/2019-04-01/deploymentTemplate.json#"",
""contentVersion"": ""1.0.0.0"",
""languageVersion"": ""1.9-experimental"",
""definitions"": {},
""resources"": {},
""parameters"": {
""refParam"": {
Expand All @@ -223,6 +225,9 @@ public void Model_handles_missing_type_reference_targets()
", "refParam");

parameterType.Type.Should().BeOfType<ErrorType>();
var loadError = parameterType.Type.GetDiagnostics().Single();
loadError.Code.Should().Be("BCP319");
loadError.Message.Should().Be("The type at \"parameters.refParam.$ref\" could not be resolved by the ARM JSON template engine. Original error message: \"Invalid reference encountered at 'parameters.refParam.$ref'. '#/definitions' not found in template. Please see https://aka.ms/arm-syntax-parameters for usage details.\"");
}

[TestMethod]
Expand Down
24 changes: 12 additions & 12 deletions src/Bicep.Core.UnitTests/packages.lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,8 @@
},
"Azure.Deployments.Core": {
"type": "Transitive",
"resolved": "1.0.788",
"contentHash": "7sK2ff4cDx9Ham/4DnbpZ2HL9cwnqEMsW8fWqM20dh9xoCTv8g2EGTw7MSMTHSJvqjJVSce+mEr6ldJfpfsDMA==",
"resolved": "1.0.815",
"contentHash": "vY5jCUjlm0xLGd/losAWT7w9NsL99WydtJ2ms5DmGcS6mmNmYdUedf4JiCHjTqU8OG+5niOi2BBTtLqTV7u4iw==",
"dependencies": {
"Microsoft.PowerPlatform.ResourceStack": "6.0.0.1423",
"Newtonsoft.Json": "13.0.1",
Expand All @@ -154,20 +154,20 @@
},
"Azure.Deployments.Expression": {
"type": "Transitive",
"resolved": "1.0.788",
"contentHash": "NWQygy/uUMYQB8JXP1CnorMs9J/zkszEk+nk3dAjAHDFjBbj8potaDyv1vq9E+KiUSvR5NFXHc1YVOvTBdLZ/Q==",
"resolved": "1.0.815",
"contentHash": "hZwwN96E02EKlm0u6zD53jr69nuJOdN3rTp/9ZjV6x+2OjW5ixofx17Z2pWU8qFmH82dy42PgYBysDhppw5GGA==",
"dependencies": {
"Azure.Deployments.Core": "1.0.788",
"Azure.Deployments.Core": "1.0.815",
"Newtonsoft.Json": "13.0.1"
}
},
"Azure.Deployments.Templates": {
"type": "Transitive",
"resolved": "1.0.788",
"contentHash": "PuTc4Sq67xIi4Apu/v0CsIpzLBr43B+V231aLPlurCHJStir/BZGPPYDh+sXvpY/+zcMWn1j6A74Rv2Isrtr5A==",
"resolved": "1.0.815",
"contentHash": "c0d9o56MzPiTjGtAsXjOOnHh7FlVlb9BAMci9os1ET+mkkBRw0C0l6QlEzve/w62iHt9nD4hYD43YP4/g7gU0Q==",
"dependencies": {
"Azure.Deployments.Core": "1.0.788",
"Azure.Deployments.Expression": "1.0.788",
"Azure.Deployments.Core": "1.0.815",
"Azure.Deployments.Expression": "1.0.815",
"Newtonsoft.Json": "13.0.1"
}
},
Expand Down Expand Up @@ -1988,9 +1988,9 @@
"Azure.Bicep.Types.Az": "[0.2.238, )",
"Azure.Bicep.Types.K8s": "[0.1.233, )",
"Azure.Containers.ContainerRegistry": "[1.1.0-beta.4, )",
"Azure.Deployments.Core": "[1.0.788, )",
"Azure.Deployments.Expression": "[1.0.788, )",
"Azure.Deployments.Templates": "[1.0.788, )",
"Azure.Deployments.Core": "[1.0.815, )",
"Azure.Deployments.Expression": "[1.0.815, )",
"Azure.Deployments.Templates": "[1.0.815, )",
"Azure.Identity": "[1.8.1, )",
"Azure.ResourceManager.Resources": "[1.3.1, )",
"JsonPatch.Net": "[2.0.4, )",
Expand Down
6 changes: 3 additions & 3 deletions src/Bicep.Core/Bicep.Core.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@
<PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="6.0.0" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.2" />
<PackageReference Include="System.Collections.Immutable" Version="6.0.0" />
<PackageReference Include="Azure.Deployments.Core" Version="1.0.788" />
<PackageReference Include="Azure.Deployments.Templates" Version="1.0.788" />
<PackageReference Include="Azure.Deployments.Expression" Version="1.0.788" />
<PackageReference Include="Azure.Deployments.Core" Version="1.0.815" />
<PackageReference Include="Azure.Deployments.Templates" Version="1.0.815" />
<PackageReference Include="Azure.Deployments.Expression" Version="1.0.815" />
<PackageReference Include="Azure.Bicep.Types" Version="0.3.61" />
<PackageReference Include="Azure.Bicep.Types.Az" Version="0.2.238" />
<PackageReference Include="Azure.Bicep.Types.K8s" Version="0.1.233" />
Expand Down
20 changes: 5 additions & 15 deletions src/Bicep.Core/Diagnostics/DiagnosticBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1782,21 +1782,6 @@ public ErrorDiagnostic NestedRuntimePropertyAccessNotSupported(string? resourceS
"BCP311",
$@"The provided index value of ""{indexSought}"" is not valid for type ""{typeName}"". Indexes for this type must be between 0 and {tupleLength - 1}");

public ErrorDiagnostic CyclicArmTypeRefs(IEnumerable<string> cycleLinks) => new(
TextSpan,
"BCP312",
$@"Type reference cycle detected in the linked ARM JSON file (""{string.Join(" -> ", cycleLinks.Select(l => $@"""{l}"""))}"").");

public ErrorDiagnostic ArmTypeRefTargetNotFound(string refSansTarget) => new(
TextSpan,
"BCP313",
$@"The ""{refSansTarget}"" type definition could not be found in the linked ARM JSON file.");

public ErrorDiagnostic ArmTypeDefHasNoTypeOrRef(string invalidTypeDef) => new(
TextSpan,
"BCP314",
$@"The ""{invalidTypeDef}"" type definition in the linked ARM JSON file is invalid because it has neither a ""type"" property nor a ""$ref"" property.");

public ErrorDiagnostic MultipleAdditionalPropertiesDeclarations() => new(
TextSpan,
"BCP315",
Expand Down Expand Up @@ -1824,6 +1809,11 @@ public ErrorDiagnostic NestedRuntimePropertyAccessNotSupported(string? resourceS
false,
CodeFixKind.QuickFix,
new(baseExpression.Span, SyntaxFactory.AsNonNullable(baseExpression).ToTextPreserveFormatting())));

public ErrorDiagnostic UnresolvableArmJsonType(string errorSource, string message) => new(
TextSpan,
"BCP319",
$@"The type at ""{errorSource}"" could not be resolved by the ARM JSON template engine. Original error message: ""{message}""");
}

public static DiagnosticBuilderInternal ForPosition(TextSpan span)
Expand Down
Loading