[Chat] Wrap UI tests with themeProvider by default#4574
Merged
Leah-Xia-Microsoft merged 6 commits intomainfrom May 3, 2024
Merged
Conversation
Leah-Xia-Microsoft
requested review from
AmyL219,
JamesBurnside,
JoshuaLai,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
Leah-Xia-Microsoft
added
does not need changelog
github-actions
Bot
removed
the
update_snapshots
Contributor
Chat bundle size is not changed.
|
Contributor
Calling bundle size is not changed.
|
Contributor
CallWithChat bundle size is not changed.
|
Contributor
…ts' of https://github.com/Azure/communication-ui-library into leahxia/add-theme-provider-wrap-to-all-UI-test-components
Contributor
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
vhuseinova-msft
approved these changes
May 3, 2024
palatter
reviewed
May 3, 2024
Member
There was a problem hiding this comment.
What causes the size difference here?
Member
Author
There was a problem hiding this comment.
What causes the size difference here?
I think it's because of adding a wrapper layer of the FluentThemeProvider, which might added some padding?
Member
Author
There was a problem hiding this comment.
Also checked on the storybook implementation, there is this 1px ish purple area added with the wrapper
Contributor
palatter
approved these changes
May 3, 2024
Contributor
Leah-Xia-Microsoft
deleted the
leahxia/add-theme-provider-wrap-to-all-UI-test-components
branch
Leah-Xia-Microsoft
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Before, we need to wrap up the UI components into FluentThemeProvider in each test. Now we move it into the beforeMount in the index.ts and have the flexibility to disable it by passing in a prop.
Ref:
Playwright related PR: microsoft/playwright#18616 (comment)
Playwright doc: https://playwright.dev/docs/test-components#hooks
Why
How Tested
Process & policy checklist
Is this a breaking change?